Skip to content

Commit 03254f4

Browse files
committed
Tests: MeiliSearchCommunicationError and MeiliSearchApiError
1 parent 48f3dbc commit 03254f4

File tree

5 files changed

+37
-7
lines changed

5 files changed

+37
-7
lines changed

meilisearch/_httprequests.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ def __init__(self, config):
1313
'Content-Type': 'application/json'
1414
}
1515

16-
1716
def get(self, path):
1817
try:
1918
request = requests.get(
@@ -22,7 +21,7 @@ def get(self, path):
2221
)
2322
return self.__validate(request)
2423
except requests.exceptions.ConnectionError as err:
25-
raise MeiliSearchCommunicationError(err) from None
24+
raise MeiliSearchCommunicationError(err)
2625

2726
def post(self, path, body=None):
2827
if body is None:
@@ -35,7 +34,7 @@ def post(self, path, body=None):
3534
)
3635
return self.__validate(request)
3736
except requests.exceptions.ConnectionError as err:
38-
raise MeiliSearchCommunicationError(err) from None
37+
raise MeiliSearchCommunicationError(err)
3938
def put(self, path, body=None):
4039
if body is None:
4140
body = {}
@@ -47,7 +46,7 @@ def put(self, path, body=None):
4746
)
4847
return self.__validate(request)
4948
except requests.exceptions.ConnectionError as err:
50-
raise MeiliSearchCommunicationError(err) from None
49+
raise MeiliSearchCommunicationError(err)
5150

5251
def delete(self, path, body=None):
5352
if body is None:
@@ -60,7 +59,7 @@ def delete(self, path, body=None):
6059
)
6160
return self.__validate(request)
6261
except requests.exceptions.ConnectionError as err:
63-
raise MeiliSearchCommunicationError(err) from None
62+
raise MeiliSearchCommunicationError(err)
6463

6564
@staticmethod
6665
def __to_json(request):
@@ -74,4 +73,4 @@ def __validate(request):
7473
request.raise_for_status()
7574
return HttpRequests.__to_json(request)
7675
except requests.exceptions.HTTPError as err:
77-
raise MeiliSearchApiError(err, request) from None
76+
raise MeiliSearchApiError(err, request)

meilisearch/errors.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ def __str__(self):
2525
return f'MeiliSearchApiError, HTTP status: {self.status_code} -> {self.message}'
2626

2727
class MeiliSearchCommunicationError(MeiliSearchError):
28-
"""Error stablishing a connection to MeiliSearch"""
28+
"""Error connecting to MeiliSearch"""
2929

3030
def __str__(self):
3131
return f'MeiliSearchCommunicationError, {self.message}'

meilisearch/tests/errors/__init__.py

Whitespace-only changes.
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
import pytest
2+
import meilisearch
3+
from meilisearch.errors import MeiliSearchApiError
4+
from meilisearch.tests import BASE_URL, MASTER_KEY
5+
6+
class TestMeiliSearchApiError:
7+
8+
""" TESTS: MeiliSearchApiError class """
9+
10+
def test_meilisearch_api_error_no_master_key(self):
11+
client = meilisearch.Client(BASE_URL)
12+
with pytest.raises(MeiliSearchApiError):
13+
client.create_index("Some index")
14+
15+
def test_meilisearch_api_error_WRONG_master_key(self):
16+
client = meilisearch.Client(BASE_URL, MASTER_KEY + '123')
17+
with pytest.raises(MeiliSearchApiError):
18+
client.create_index("Some index")
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
import pytest
2+
import meilisearch
3+
from meilisearch.errors import MeiliSearchCommunicationError
4+
from meilisearch.tests import MASTER_KEY
5+
6+
class TestMeiliSearchCommunicationError:
7+
8+
""" TESTS: MeiliSearchCommunicationError class """
9+
10+
def test_meilisearch_communication_error_host(self):
11+
client = meilisearch.Client("http://localhost:1234", MASTER_KEY)
12+
with pytest.raises(MeiliSearchCommunicationError):
13+
client.create_index("Some index")

0 commit comments

Comments
 (0)