Update settings behavior (#138)

Remove acceptNewFields routes
Update tests for settings

Author: eskombro

.code-samples.meilisearch.yaml

@@ -148,10 +148,6 @@ update_displayed_attributes_1: |-
   ])
 reset_displayed_attributes_1: |-
   client.get_index('movies').reset_displayed_attributes()
-get_accept_new_fields_1: |-
-  client.get_index('movies').get_accept_new_fields()
-update_accept_new_fields_1: |-
-  client.get_index('movies').update_accept_new_fields(False)
 get_index_stats_1: |-
   client.get_index('movies').get_stats()
 get_indexes_stats_1: |-
@@ -287,10 +283,6 @@ settings_guide_displayed_1: |-
       'rank'
     ]
   })
-settings_guide_accept_new_fields_1: |-
-  client.get_index('movies').update_settings({
-    'acceptNewFields': False
-  })
 documents_guide_add_movie_1: |-
   client.get_index('movies').add_documents([{
     'movie_id': '123sq178',

meilisearch/index.py

@@ -773,41 +773,6 @@ def reset_synonyms(self):
             self.__settings_url_for(self.config.paths.synonyms),
         )
 
-    # ACCEPT-NEW-FIELDS SUB-ROUTES
-
-    def get_accept_new_fields(self):
-        """
-        Get accept-new-fields value of an index
-
-        Returns
-        ----------
-        settings: `bool`
-            Boolean containing the accept-new-fields value of the index
-        """
-        return self.http.get(
-            self.__settings_url_for(self.config.paths.accept_new_fields)
-        )
-
-    def update_accept_new_fields(self, body):
-        """
-        Update accept-new-fields value of an index
-
-        Parameters
-        ----------
-        body: `bool`
-            Boolean containing the accept-new-fields value
-
-        Returns
-        ----------
-        update: `dict`
-            Dictionnary containing an update id to track the action:
-            https://docs.meilisearch.com/references/updates.html#get-an-update-status
-        """
-        return self.http.post(
-            self.__settings_url_for(self.config.paths.accept_new_fields),
-            body
-        )
-
     # ATTRIBUTES FOR FACETING SUB-ROUTES
 
     def get_attributes_for_faceting(self):

meilisearch/tests/settings/test_settings.py

@@ -33,11 +33,10 @@ def test_get_settings_default(self):
         for rule in self.default_ranking_rules:
             assert rule in response['rankingRules']
         assert response['distinctAttribute'] is None
-        assert response['searchableAttributes'] == []
-        assert response['displayedAttributes'] == []
+        assert response['searchableAttributes'] == ['*']
+        assert response['displayedAttributes'] == ['*']
         assert response['stopWords'] == []
         assert response['synonyms'] == {}
-        assert response['acceptNewFields'] is True
 
     def test_update_settings(self):
         """Tests updating some settings"""
@@ -52,10 +51,9 @@ def test_update_settings(self):
         assert response['distinctAttribute'] is None
         for attribute in self.new_settings['searchableAttributes']:
             assert attribute in response['searchableAttributes']
-        assert response['displayedAttributes'] == []
+        assert response['displayedAttributes'] == ['*']
         assert response['stopWords'] == []
         assert response['synonyms'] == {}
-        assert response['acceptNewFields'] is True
 
     def test_reset_settings(self):
         """Tests resetting default settings"""
@@ -68,9 +66,7 @@ def test_reset_settings(self):
         for rule in self.default_ranking_rules:
             assert rule in response['rankingRules']
         assert response['distinctAttribute'] is None
-        for attribute in self.new_settings['searchableAttributes']:
-            assert attribute in response['searchableAttributes']
-            assert attribute in response['displayedAttributes']
+        assert response['displayedAttributes'] == ['*']
+        assert response['searchableAttributes'] == ['*']
         assert response['stopWords'] == []
         assert response['synonyms'] == {}
-        assert response['acceptNewFields'] is True

meilisearch/tests/settings/test_settings_accept_new_fields_meilisearch.py

@@ -25,21 +25,21 @@ def test_get_displayed_attributes(self):
         """ Tests getting the displayed attributes before and after indexing a dataset """
         response = self.index.get_displayed_attributes()
         assert isinstance(response, object)
-        assert response == []
+        assert response == ['*']
         response = self.index.add_documents(self.dataset_json, primary_key='id')
         self.index.wait_for_pending_update(response['updateId'])
         get_attributes = self.index.get_displayed_attributes()
-        for attribute in self.displayed_attributes:
-            assert attribute in get_attributes
+        assert get_attributes == ['*']
 
     def test_update_displayed_attributes(self):
         """Tests updating the displayed attributes"""
         get_attributes = self.index.get_displayed_attributes()
-        response = self.index.update_displayed_attributes(get_attributes[1:])
+        response = self.index.update_displayed_attributes(self.displayed_attributes)
         self.index.wait_for_pending_update(response['updateId'])
         get_attributes_new = self.index.get_displayed_attributes()
-        assert len(get_attributes_new) == len(self.displayed_attributes) - 1
-        assert get_attributes[0] not in get_attributes_new
+        assert len(get_attributes_new) == len(self.displayed_attributes)
+        for attribute in self.displayed_attributes:
+            assert attribute in get_attributes_new
 
     def test_reset_displayed_attributes(self):
         """Tests the reset of displayedAttributes to default values (in dataset)"""
@@ -48,6 +48,4 @@ def test_reset_displayed_attributes(self):
         assert 'updateId' in response
         self.index.wait_for_pending_update(response['updateId'])
         get_attributes = self.index.get_displayed_attributes()
-        assert len(get_attributes) == len(self.displayed_attributes)
-        for attribute in self.displayed_attributes:
-            assert attribute in get_attributes
+        assert get_attributes == ['*']

meilisearch/tests/settings/test_settings_displayed_attributes_meilisearch.py

@@ -26,12 +26,11 @@ def test_get_searchable_attributes(self):
         """Tests getting the searchable attributes on an empty and populated index"""
         response = self.index.get_searchable_attributes()
         assert isinstance(response, object)
-        assert response == []
+        assert response == ['*']
         response = self.index.add_documents(self.dataset_json, primary_key='id')
         self.index.wait_for_pending_update(response['updateId'])
         get_attributes = self.index.get_searchable_attributes()
-        for attribute in self.full_searchable_attributes:
-            assert attribute in get_attributes
+        assert get_attributes == ['*']
 
 
     def test_update_searchable_attributes(self):
@@ -41,6 +40,7 @@ def test_update_searchable_attributes(self):
         assert 'updateId' in response
         self.index.wait_for_pending_update(response['updateId'])
         response = self.index.get_searchable_attributes()
+        assert len(response) == len(self.new_searchable_attributes)
         for attribute in self.new_searchable_attributes:
             assert attribute in response
 
@@ -51,5 +51,4 @@ def test_reset_searchable_attributes(self):
         assert 'updateId' in response
         self.index.wait_for_pending_update(response['updateId'])
         response = self.index.get_searchable_attributes()
-        for attribute in self.full_searchable_attributes:
-            assert attribute in response
+        assert response == ['*']