Skip to content

Commit 143cac3

Browse files
committed
Changing default timeout to None
1 parent b7d1146 commit 143cac3

File tree

5 files changed

+4
-14
lines changed

5 files changed

+4
-14
lines changed

meilisearch/client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ class Client():
1414
config = None
1515
http = None
1616

17-
def __init__(self, url, apiKey=None, timeout=10):
17+
def __init__(self, url, apiKey=None, timeout=None):
1818
"""
1919
Parameters
2020
----------

meilisearch/config.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ class Paths():
2323
attributes_for_faceting = 'attributes-for-faceting'
2424
dumps = 'dumps'
2525

26-
def __init__(self, url, api_key=None, timeout=10):
26+
def __init__(self, url, api_key=None, timeout=None):
2727
"""
2828
Parameters
2929
----------

meilisearch/tests/client/test_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ def test_client_timeout_set():
2121

2222

2323
def test_client_timeout_not_set():
24-
default_timeout = 10
24+
default_timeout = None
2525
client = meilisearch.Client(BASE_URL, MASTER_KEY)
2626
response = client.health()
2727
assert client.config.timeout == default_timeout

meilisearch/tests/errors/test_communication_error_meilisearch.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,6 @@
1111
@patch("requests.post")
1212
def test_meilisearch_communication_error_host(mock_post):
1313
mock_post.side_effect = requests.exceptions.ConnectionError()
14-
client = meilisearch.Client("http://wrongurl:1234", MASTER_KEY, timeout=None)
14+
client = meilisearch.Client("http://wrongurl:1234", MASTER_KEY)
1515
with pytest.raises(MeiliSearchCommunicationError):
1616
client.create_index("some_index")

meilisearch/tests/errors/test_timeout_error_meilisearch.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,3 @@ def test_client_timeout_set():
2121
client.health()
2222

2323
assert client.config.timeout == timeout
24-
25-
26-
def test_client_timeout_not_set():
27-
timeout = 10
28-
client = meilisearch.Client("http://wrongurl:1234", MASTER_KEY)
29-
30-
with pytest.raises(Exception):
31-
client.health()
32-
33-
assert client.config.timeout == timeout

0 commit comments

Comments
 (0)