Skip to content

Commit 1a52721

Browse files
Merge #978
978: Fix flaky test r=sanders41 a=sanders41 # Pull Request `@curquiza` since the test is flaky there is a chance this doesn't fix the issue, but I'm pretty sure it will. ## Related issue Fixes #976 ## What does this PR do? - Remove HuggingFace from settings test ## PR checklist Please check if your PR fulfills the following requirements: - [ ] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [ ] Have you read the contributing guidelines? - [ ] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: Paul Sanders <[email protected]>
2 parents a38cbac + 013a14b commit 1a52721

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

tests/settings/test_settings.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# pylint: disable=redefined-outer-name
22
import pytest
33

4-
from meilisearch.models.index import HuggingFaceEmbedder, OpenAiEmbedder, UserProvidedEmbedder
4+
from meilisearch.models.index import OpenAiEmbedder, UserProvidedEmbedder
55

66

77
@pytest.fixture
@@ -59,7 +59,6 @@ def test_update_settings(new_settings, empty_index):
5959
assert response["synonyms"] == {}
6060
assert isinstance(response["embedders"]["default"], UserProvidedEmbedder)
6161
assert isinstance(response["embedders"]["open_ai"], OpenAiEmbedder)
62-
assert isinstance(response["embedders"]["hugging_face"], HuggingFaceEmbedder)
6362

6463

6564
@pytest.mark.usefixtures("enable_vector_search")

0 commit comments

Comments
 (0)