Skip to content

Commit 2d97c1a

Browse files
bors[bot]meili-bot
andauthored
Merge #410
410: Replace --no-analytics=true with --no-analytics r=alallema a=meili-bot _This PR is auto-generated._ Following the change in the core engine for v0.26.0, we want to remove the usage of `--no-analytics=true` and replace it by `--no-analytics`. Co-authored-by: meili-bot <[email protected]>
2 parents f0c2df2 + 66fa5f8 commit 2d97c1a

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

.github/workflows/pre-release-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,6 @@ jobs:
2929
- name: Get the latest Meilisearch RC
3030
run: echo "MEILISEARCH_VERSION=$(curl https://raw.githubusercontent.com/meilisearch/integration-guides/main/scripts/get-latest-meilisearch-rc.sh | bash)" >> $GITHUB_ENV
3131
- name: Meilisearch (${{ env.MEILISEARCH_VERSION }}) setup with Docker
32-
run: docker run -d -p 7700:7700 getmeili/meilisearch:${{ env.MEILISEARCH_VERSION }} ./meilisearch --master-key=masterKey --no-analytics=true
32+
run: docker run -d -p 7700:7700 getmeili/meilisearch:${{ env.MEILISEARCH_VERSION }} ./meilisearch --master-key=masterKey --no-analytics
3333
- name: Test with pytest
3434
run: pipenv run pytest

.github/workflows/tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ jobs:
3131
- name: Install dependencies
3232
run: pipenv install --dev
3333
- name: Meilisearch (latest version) setup with Docker
34-
run: docker run -d -p 7700:7700 getmeili/meilisearch:latest ./meilisearch --no-analytics=true --master-key=masterKey
34+
run: docker run -d -p 7700:7700 getmeili/meilisearch:latest ./meilisearch --no-analytics --master-key=masterKey
3535
- name: Test with pytest
3636
run: pipenv run pytest
3737

CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ Each PR should pass the tests, mypy type checking, and the linter to be accepted
3939
```bash
4040
# Tests
4141
curl -L https://install.meilisearch.com | sh # download Meilisearch
42-
./meilisearch --master-key=masterKey --no-analytics=true # run Meilisearch
42+
./meilisearch --master-key=masterKey --no-analytics # run Meilisearch
4343
pipenv run pytest meilisearch
4444
# MyPy
4545
pipenv run mypy meilisearch
@@ -51,7 +51,7 @@ Optionally tox can be used to run test on all supported version of Python, mypy,
5151

5252
```bash
5353
docker pull getmeili/meilisearch:latest # Fetch the latest version of Meilisearch image from Docker Hub
54-
docker run -p 7700:7700 getmeili/meilisearch:latest ./meilisearch --master-key=masterKey --no-analytics=true
54+
docker run -p 7700:7700 getmeili/meilisearch:latest ./meilisearch --master-key=masterKey --no-analytics
5555
pipenv run tox
5656
```
5757

0 commit comments

Comments
 (0)