Apply suggestions from code review

- wrapping localized_attributes in a model
- using Mapping instead of Dict

Author: ellnix

meilisearch/index.py

@@ -29,6 +29,7 @@
     Faceting,
     HuggingFaceEmbedder,
     IndexStats,
+    LocalizedAttributes,
     OpenAiEmbedder,
     Pagination,
     ProximityPrecision,
@@ -2044,8 +2045,8 @@ def reset_proximity_precision(self) -> TaskInfo:
 
     # LOCALIZED ATTRIBUTES SETTINGS
 
-    def get_localized_attributes(self) -> Union[List[Dict[str, List[str]]], None]:
-        """Get the proximity_precision of the index.
+    def get_localized_attributes(self) -> Union[List[LocalizedAttributes], None]:
+        """Get the localized_attributes of the index.
 
         Returns
         -------
@@ -2057,10 +2058,15 @@ def get_localized_attributes(self) -> Union[List[Dict[str, List[str]]], None]:
         MeilisearchApiError
             An error containing details about why Meilisearch can't process your request. Meilisearch error codes are described here: https://www.meilisearch.com/docs/reference/errors/error_codes#meilisearch-errors
         """
-        return self.http.get(self.__settings_url_for(self.config.paths.localized_attributes))
+        response = self.http.get(self.__settings_url_for(self.config.paths.localized_attributes))
+
+        if not response:
+            return None
+
+        return [LocalizedAttributes(**attrs) for attrs in response]
 
     def update_localized_attributes(
-        self, body: Union[List[Dict[str, List[str]]], None]
+        self, body: Union[List[Mapping[str, List[str]]], None]
     ) -> TaskInfo:
         """Update the localized_attributes of the index.
 

meilisearch/models/index.py

@@ -54,6 +54,11 @@ class ProximityPrecision(str, Enum):
     BY_ATTRIBUTE = "byAttribute"
 
 
+class LocalizedAttributes(CamelBase):
+    attribute_patterns: List[str]
+    locales: List[str]
+
+
 class OpenAiEmbedder(CamelBase):
     source: str = "openAi"
     model: Optional[str] = None  # Defaults to text-embedding-3-small

tests/settings/test_settings_localized_attributes_meilisearch.py

@@ -1,6 +1,14 @@
+from typing import List
+
+from meilisearch.models.index import LocalizedAttributes
+
 NEW_LOCALIZED_ATTRIBUTES = [{"attributePatterns": ["title"], "locales": ["eng"]}]
 
 
+def unpack_loc_attrs_response(response: List[LocalizedAttributes]):
+    return [loc_attrs.model_dump(by_alias=True) for loc_attrs in response]
+
+
 def test_get_localized_attributes(empty_index):
     """Tests getting default localized_attributes."""
     response = empty_index().get_localized_attributes()
@@ -14,7 +22,7 @@ def test_update_localized_attributes(empty_index):
     update = index.wait_for_task(response.task_uid)
     assert update.status == "succeeded"
     response = index.get_localized_attributes()
-    assert NEW_LOCALIZED_ATTRIBUTES == response
+    assert NEW_LOCALIZED_ATTRIBUTES == unpack_loc_attrs_response(response)
 
 
 def test_reset_localized_attributes(empty_index):
@@ -26,7 +34,7 @@ def test_reset_localized_attributes(empty_index):
     assert update.status == "succeeded"
     # Check the settings have been correctly updated
     response = index.get_localized_attributes()
-    assert NEW_LOCALIZED_ATTRIBUTES == response
+    assert NEW_LOCALIZED_ATTRIBUTES == unpack_loc_attrs_response(response)
     # Check the reset of the settings
     response = index.reset_localized_attributes()
     update = index.wait_for_task(response.task_uid)