Modification due to review

Author: alallema

meilisearch/client.py

@@ -217,7 +217,7 @@ def is_healthy(self) -> bool:
             return False
         return True
 
-    def get_key(self, key: str) -> Dict[str, str]:
+    def get_key(self, key: str) -> Dict[str, Any]:
         """Gets information about a specific API key.
 
         Parameters
@@ -238,7 +238,7 @@ def get_key(self, key: str) -> Dict[str, str]:
         """
         return self.http.get(f'{self.config.paths.keys}/{key}')
 
-    def get_keys(self) -> Dict[str, str]:
+    def get_keys(self) -> List[Dict[str, Any]]:
         """Gets the MeiliSearch API keys.
 
         Returns
@@ -256,7 +256,7 @@ def get_keys(self) -> Dict[str, str]:
 
     def create_key(
         self,
-        options: Optional[Dict[str, Any]] = None
+        options: Dict[str, Any]
     ) -> Dict[str, int]:
         """Creates a new API key.
 
@@ -288,17 +288,18 @@ def create_key(
     def udpate_key(
         self,
         key: str,
-        options: Optional[Dict[str, Any]] = None
+        options: Dict[str, Any]
     ) -> Dict[str, int]:
         """Update an API key.
 
         Parameters
+
         ----------
         key:
-            The information to use in updating the key. Note that if an expires_at value
-            is included it should be in UTC time.
+            The key for which to update the information.
         options:
-            Options, the information to use in creating the key (ex: { 'description': 'Search Key', 'expiresAt': '22-01-01' }).
+            The information to use in creating the key (ex: { 'description': 'Search Key', 'expiresAt': '22-01-01' }). Note that if an
+            expires_at value is included it should be in UTC time.
 
         Returns
         -------

tests/client/test_client_key_meilisearch.py

@@ -1,12 +1,12 @@
 import pytest
 from tests import common
-from datetime import datetime, timedelta
+from datetime import datetime
 
 def test_get_keys_default(client):
     """Tests if public and private keys have been generated and can be retrieved."""
     key = client.get_keys()
     assert isinstance(key, list)
-    assert len(key) >= 2
+    assert len(key) == 2
     assert 'actions' in key[0]
     assert 'indexes' in key[0]
     assert key[0]['key'] is not None
@@ -40,6 +40,7 @@ def test_create_keys_default(client):
     assert key['key'] is not None
     assert key['actions'] == ['*']
     assert key['indexes'] == [common.INDEX_UID]
+    client.delete_key(key['key'])
 
 def test_create_keys_with_options(client):
     """Tests the creation of a key with arguments."""
@@ -52,6 +53,7 @@ def test_create_keys_with_options(client):
     assert key['updatedAt'] is not None
     assert key['actions'] == ['*']
     assert key['indexes'] == [common.INDEX_UID]
+    client.delete_key(key['key'])
 
 def test_create_keys_without_actions(client):
     """Tests the creation of a key with missing arguments."""
@@ -66,6 +68,7 @@ def test_update_keys(client):
     assert update_key['key'] is not None
     assert update_key['expiresAt'] is None
     assert update_key['actions'] == ['search']
+    client.delete_key(update_key['key'])
 
 def test_delete_key(client):
     """Tests deleting a key."""