Adapt the tests for csv delimiter

Author: alallema

datasets/songs_delimiter.csv renamed to datasets/songs_custom_delimiter.csv

@@ -77,11 +77,11 @@ def songs_csv():
 
 
 @fixture(scope="session")
-def songs_csv_delimiter():
+def songs_csv_custom_separator():
     """
-    Runs once per session. Provides the content of songs_delimiter.csv from read..
+    Runs once per session. Provides the content of songs_custom_delimiter.csv from read..
     """
-    with open("./datasets/songs_delimiter.csv", encoding="utf-8") as song_csv_file:
+    with open("./datasets/songs_custom_delimiter.csv", encoding="utf-8") as song_csv_file:
         return song_csv_file.read().encode("utf-8")
 
 

tests/conftest.py

@@ -197,14 +197,18 @@ def test_add_documents_csv(empty_index, songs_csv):
     assert index.get_primary_key() == "id"
 
 
-def test_add_documents_csv_with_delimiter(empty_index, songs_csv_delimiter):
+def test_add_documents_csv_with_delimiter(empty_index, songs_csv_custom_separator):
     """Tests adding new documents to a clean index."""
     index = empty_index("csv-delimiter")
-    response = index.add_documents_csv(songs_csv_delimiter, csv_delimiter=";")
+    response = index.add_documents_csv(songs_csv_custom_separator, csv_delimiter=";")
     assert isinstance(response, TaskInfo)
     assert response.task_uid is not None
     task = index.wait_for_task(response.task_uid)
     assert task.status == "succeeded"
+    assert task.details["receivedDocuments"] == 53
+    documents = index.get_documents().results
+    assert documents[1].country == "Europe"
+    assert documents[4].artist == "Elton John"
 
 
 def test_update_documents_csv(index_with_documents, songs_csv):
@@ -218,14 +222,18 @@ def test_update_documents_csv(index_with_documents, songs_csv):
     assert index.get_primary_key() == "id"
 
 
-def test_update_documents_csv_with_delimiter(index_with_documents, songs_csv_delimiter):
+def test_update_documents_csv_with_delimiter(index_with_documents, songs_csv_custom_separator):
     """Tests adding new documents to a clean index."""
-    index = index_with_documents("csv-delimiter")
-    response = index.update_documents_csv(songs_csv_delimiter, csv_delimiter=";")
+    index = index_with_documents()
+    response = index.update_documents_csv(songs_csv_custom_separator, csv_delimiter=";")
     assert isinstance(response, TaskInfo)
     assert response.task_uid is not None
     task = index.wait_for_task(response.task_uid)
     assert task.status == "succeeded"
+    assert task.details["receivedDocuments"] == 53
+    document = index.get_document("813645611")
+    assert document.country == "Europe"
+    assert document.artist == "Elton John"
 
 
 def test_add_documents_json(empty_index, small_movies_json_file):