Skip to content

Commit 68d915b

Browse files
committed
Changes after review
1 parent ea69bea commit 68d915b

File tree

3 files changed

+168
-72
lines changed

3 files changed

+168
-72
lines changed

meilisearch/client.py

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
from meilisearch.index import Index
44
from meilisearch.config import Config
5+
from meilisearch.task import Task
56
from meilisearch._httprequests import HttpRequests
67
from meilisearch.errors import MeiliSearchError
78

@@ -362,24 +363,22 @@ def get_tasks(self) -> Dict[str, List[Dict[str, Any]]]:
362363
Returns
363364
-------
364365
task:
365-
Dictionary containing a list of all enqueued, processing, succeeded or failed tasks of the index.
366+
Dictionary containing a list of all enqueued, processing, succeeded or failed tasks.
366367
367368
Raises
368369
------
369370
MeiliSearchApiError
370371
An error containing details about why MeiliSearch can't process your request. MeiliSearch error codes are described here: https://docs.meilisearch.com/errors/#meilisearch-errors
371372
"""
372-
return self.http.get(
373-
f'{self.config.paths.task}'
374-
)
373+
return Task(self.config).get_tasks()
375374

376375
def get_task(self, uid: int) -> Dict[str, Any]:
377376
"""Get one task.
378377
379378
Parameters
380379
----------
381380
uid:
382-
identifier of the task.
381+
Identifier of the task.
383382
384383
Returns
385384
-------
@@ -391,9 +390,7 @@ def get_task(self, uid: int) -> Dict[str, Any]:
391390
MeiliSearchApiError
392391
An error containing details about why MeiliSearch can't process your request. MeiliSearch error codes are described here: https://docs.meilisearch.com/errors/#meilisearch-errors
393392
"""
394-
return self.http.get(
395-
f'{self.config.paths.task}/{uid}'
396-
)
393+
return Task(self.config).get_task(uid)
397394

398395
def wait_for_task(
399396
self, uid: int,
@@ -405,11 +402,11 @@ def wait_for_task(
405402
Parameters
406403
----------
407404
uid:
408-
identifier of the task to wait for being processed.
405+
Identifier of the task to wait for being processed.
409406
timeout_in_ms (optional):
410-
time the method should wait before raising a MeiliSearchTimeoutError
407+
Time the method should wait before raising a MeiliSearchTimeoutError
411408
interval_in_ms (optional):
412-
time interval the method should wait (sleep) between requests
409+
Time interval the method should wait (sleep) between requests
413410
414411
Returns
415412
-------
@@ -421,4 +418,4 @@ def wait_for_task(
421418
MeiliSearchTimeoutError
422419
An error containing details about why MeiliSearch can't process your request. MeiliSearch error codes are described here: https://docs.meilisearch.com/errors/#meilisearch-errors
423420
"""
424-
return Index(self.config, str(uid)).wait_for_task(uid, timeout_in_ms, interval_in_ms)
421+
return Task(self.config).wait_for_task(uid, timeout_in_ms, interval_in_ms)

0 commit comments

Comments
 (0)