Skip to content

Commit 805d1e4

Browse files
committed
Change get_task parameter name
1 parent d053e9f commit 805d1e4

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

meilisearch/client.py

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -79,13 +79,13 @@ def delete_index(self, uid: str) -> Dict[str, Any]:
7979

8080
return self.http.delete(f'{self.config.paths.index}/{uid}')
8181

82-
def get_indexes(self, resource_query: Optional[Dict[str, Any]] = None) -> Dict[str, List[Index]]:
82+
def get_indexes(self, parameters: Optional[Dict[str, Any]] = None) -> Dict[str, List[Index]]:
8383
"""Get all indexes.
8484
8585
Parameters
8686
----------
87-
resource_query (optional):
88-
resource_query accepted by the get indexes route: https://docs.meilisearch.com/reference/api/indexes.html#list-all-indexes
87+
parameters (optional):
88+
parameters accepted by the get indexes route: https://docs.meilisearch.com/reference/api/indexes.html#list-all-indexes
8989
9090
Returns
9191
-------
@@ -97,10 +97,10 @@ def get_indexes(self, resource_query: Optional[Dict[str, Any]] = None) -> Dict[s
9797
MeiliSearchApiError
9898
An error containing details about why Meilisearch can't process your request. Meilisearch error codes are described here: https://docs.meilisearch.com/errors/#meilisearch-errors
9999
"""
100-
if resource_query is None:
101-
resource_query = {}
100+
if parameters is None:
101+
parameters = {}
102102
response = self.http.get(
103-
f'{self.config.paths.index}?{parse.urlencode(resource_query)}'
103+
f'{self.config.paths.index}?{parse.urlencode(parameters)}'
104104
)
105105
response['results'] = [
106106
Index(
@@ -114,13 +114,13 @@ def get_indexes(self, resource_query: Optional[Dict[str, Any]] = None) -> Dict[s
114114
]
115115
return response
116116

117-
def get_raw_indexes(self, resource_query: Optional[Dict[str, Any]] = None) -> List[Dict[str, Any]]:
117+
def get_raw_indexes(self, parameters: Optional[Dict[str, Any]] = None) -> List[Dict[str, Any]]:
118118
"""Get all indexes in dictionary format.
119119
120120
Parameters
121121
----------
122-
resource_query (optional):
123-
resource_query accepted by the get indexes route: https://docs.meilisearch.com/reference/api/indexes.html#list-all-indexes
122+
parameters (optional):
123+
parameters accepted by the get indexes route: https://docs.meilisearch.com/reference/api/indexes.html#list-all-indexes
124124
125125
Returns
126126
-------
@@ -132,10 +132,10 @@ def get_raw_indexes(self, resource_query: Optional[Dict[str, Any]] = None) -> Li
132132
MeiliSearchApiError
133133
An error containing details about why Meilisearch can't process your request. Meilisearch error codes are described here: https://docs.meilisearch.com/errors/#meilisearch-errors
134134
"""
135-
if resource_query is None:
136-
resource_query = {}
135+
if parameters is None:
136+
parameters = {}
137137
return self.http.get(
138-
f'{self.config.paths.index}?{parse.urlencode(resource_query)}'
138+
f'{self.config.paths.index}?{parse.urlencode(parameters)}'
139139
)
140140

141141
def get_index(self, uid: str) -> Index:

tests/index/test_index.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,9 @@ def test_get_indexes(client):
4848
assert len(response['results']) == 3
4949

5050
@pytest.mark.usefixtures("indexes_sample")
51-
def test_get_indexes_with_resource_query(client):
51+
def test_get_indexes_with_parameters(client):
5252
"""Tests getting all indexes."""
53-
response = client.get_indexes(resource_query={'limit':1, 'offset': 1})
53+
response = client.get_indexes(parameters={'limit':1, 'offset': 1})
5454
assert len(response['results']) == 1
5555

5656
@pytest.mark.usefixtures("indexes_sample")
@@ -64,8 +64,8 @@ def test_get_raw_indexes(client):
6464
assert len(response['results']) == 3
6565

6666
@pytest.mark.usefixtures("indexes_sample")
67-
def test_get_raw_indexeswith_resource_query(client):
68-
response = client.get_raw_indexes(resource_query={'limit':1, 'offset': 1})
67+
def test_get_raw_indexeswith_parameters(client):
68+
response = client.get_raw_indexes(parameters={'limit':1, 'offset': 1})
6969
assert isinstance(response['results'], list)
7070
assert len(response['results']) == 1
7171

0 commit comments

Comments
 (0)