Skip to content

Commit 89a9083

Browse files
committed
revert coderabbit
1 parent 33c574d commit 89a9083

File tree

2 files changed

+19
-1
lines changed

2 files changed

+19
-1
lines changed

meilisearch/models/embedders.py

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -227,13 +227,30 @@ class CompositeEmbedder(CamelBase):
227227
RestEmbedder,
228228
UserProvidedEmbedder,
229229
]
230+
search_embedder: Union[
231+
OpenAiEmbedder,
232+
HuggingFaceEmbedder,
233+
OllamaEmbedder,
234+
RestEmbedder,
235+
UserProvidedEmbedder,
236+
]"""
237+
238+
source: str = "composite"
230239
search_embedder: Union[
231240
OpenAiEmbedder,
232241
HuggingFaceEmbedder,
233242
OllamaEmbedder,
234243
RestEmbedder,
235244
UserProvidedEmbedder,
236245
]
246+
indexing_embedder: Union[
247+
OpenAiEmbedder,
248+
HuggingFaceEmbedder,
249+
OllamaEmbedder,
250+
RestEmbedder,
251+
UserProvidedEmbedder,
252+
]
253+
237254

238255
# Type alias for the embedder union type
239256
EmbedderType = Union[

tests/settings/test_settings_embedders.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
CompositeEmbedder,
77
HuggingFaceEmbedder,
88
OpenAiEmbedder,
9+
PoolingType,
910
UserProvidedEmbedder,
1011
)
1112

@@ -104,7 +105,7 @@ def test_huggingface_embedder_format(empty_index):
104105
assert embedders.embedders["huggingface"].distribution.mean == 0.5
105106
assert embedders.embedders["huggingface"].distribution.sigma == 0.1
106107
assert embedders.embedders["huggingface"].binary_quantized is False
107-
assert embedders.embedders["huggingface"].pooling is False
108+
assert embedders.embedders["huggingface"].pooling is PoolingType.USE_MODEL
108109

109110

110111
def test_ollama_embedder_format(empty_index):

0 commit comments

Comments
 (0)