Skip to content

Commit 8f4d1ef

Browse files
committed
Improve tests
1 parent 463ea19 commit 8f4d1ef

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

tests/client/test_client_task_meilisearch.py

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ def test_get_tasks_with_all_plural_parameters(client, empty_index):
4545
{"indexUids": [common.INDEX_UID], "statuses": ["succeeded"], "types": ["indexCreation"]}
4646
)
4747
assert isinstance(tasks, dict)
48-
assert len(tasks["results"]) > 1
48+
assert len(tasks["results"]) >= 1
4949

5050

5151
def test_get_tasks_with_date_parameters(client, empty_index):
@@ -136,28 +136,34 @@ def test_cancel_every_task(client):
136136
def test_delete_tasks_by_uid(client, empty_index, small_movies):
137137
"""Tests getting a task of an inexistent operation."""
138138
index = empty_index()
139-
task = index.add_documents(small_movies)
140-
task_deleted = client.delete_tasks({"uids": task.task_uid})
139+
task_addition = index.add_documents(small_movies)
140+
task_deleted = client.delete_tasks({"uids": task_addition.task_uid})
141141
client.wait_for_task(task_deleted.task_uid)
142142
with pytest.raises(Exception):
143-
client.get_task(task.task_uid)
143+
client.get_task(task_addition.task_uid)
144+
task = client.get_task(task_deleted.task_uid)
144145

145146
assert isinstance(task_deleted, TaskInfo)
146147
assert task_deleted.task_uid is not None
147148
assert task_deleted.index_uid is None
148-
assert task_deleted.status == "enqueued" or "processing" or "succeeded"
149149
assert task_deleted.type == "taskDeletion"
150+
assert "uids" in task["details"]["originalFilter"]
151+
assert f"uids={task_addition.task_uid}" in task["details"]["originalFilter"]
150152

151153

152154
def test_delete_all_tasks(client):
153155
tasks_before = client.get_tasks()
154156
task = client.delete_tasks({"statuses": ["succeeded", "failed", "canceled"]})
157+
client.wait_for_task(task.task_uid)
155158
tasks_after = client.get_tasks()
156159

157160
assert isinstance(task, TaskInfo)
158161
assert task.task_uid is not None
159162
assert task.index_uid is None
160-
assert task.status == "enqueued" or "processing" or "succeeded"
161163
assert task.type == "taskDeletion"
162164
assert len(tasks_after["results"]) == 1
163165
assert len(tasks_before["results"]) == len(tasks_after["results"])
166+
assert (
167+
"statuses=succeeded%2Cfailed%2Ccanceled"
168+
in tasks_after["results"][0]["details"]["originalFilter"]
169+
)

0 commit comments

Comments
 (0)