Skip to content

Commit 95ac7b4

Browse files
Merge #433
433: Feature/Analytics r=alallema a=brunoocasali Added a pre-defined User-Agent header using `meilisearch.version` After the implementation the MeiliSearch server is outputting the expected 💯 `[2022-03-30T04:41:46Z INFO actix_web::middleware::logger] 192.168.208.3 "GET /indexes HTTP/1.1" 200 2 "-" "Meilisearch Python (v0.18.1)" 0.000619` Add Python support as requested here meilisearch/integration-guides#150 Related to #409 Co-authored-by: Bruno Casali <[email protected]>
2 parents f9d5fa2 + bfbba9e commit 95ac7b4

File tree

2 files changed

+17
-0
lines changed

2 files changed

+17
-0
lines changed

meilisearch/_httprequests.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,14 @@
77
MeiliSearchCommunicationError,
88
MeiliSearchTimeoutError,
99
)
10+
from meilisearch.version import qualified_version
1011

1112
class HttpRequests:
1213
def __init__(self, config: Config) -> None:
1314
self.config = config
1415
self.headers = {
1516
'Authorization': f'Bearer {self.config.api_key}',
17+
'User-Agent': qualified_version(),
1618
}
1719

1820
def send_request(

tests/client/test_http_requests.py

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
2+
import meilisearch
3+
from tests import BASE_URL, MASTER_KEY
4+
5+
from meilisearch.config import Config
6+
from meilisearch._httprequests import HttpRequests
7+
from meilisearch.version import qualified_version
8+
9+
def test_get_headers_from_http_requests_instance():
10+
"""Tests getting defined headers from instance in HttpRequests."""
11+
config = Config(BASE_URL, MASTER_KEY, timeout=None)
12+
http = HttpRequests(config=config)
13+
14+
assert http.headers['Authorization'] == f"Bearer {MASTER_KEY}"
15+
assert http.headers['User-Agent'] == qualified_version()

0 commit comments

Comments
 (0)