Improve test readability

Author: alallema

tests/settings/test_settings_typo_tolerance_meilisearch.py

@@ -28,51 +28,39 @@ def test_get_typo_tolerance_default(empty_index):
 def test_update_typo_tolerance(empty_index):
     """Tests updating typo_tolerance."""
     index = empty_index()
+    response_update = index.update_typo_tolerance(NEW_TYPO_TOLERANCE)
+    update = index.wait_for_task(response_update['uid'])
+    response_get = index.get_typo_tolerance()
 
-    response = index.update_typo_tolerance(NEW_TYPO_TOLERANCE)
-
-    assert isinstance(response, dict)
-    assert 'uid' in response
-
-    update = index.wait_for_task(response['uid'])
-
+    assert isinstance(response_update, dict)
+    assert 'uid' in response_update
     assert update['status'] == 'succeeded'
-
-    response = index.get_typo_tolerance()
-
-    assert isinstance(response, dict)
+    assert isinstance(response_get, dict)
     for typo_tolerance in NEW_TYPO_TOLERANCE:
-        assert typo_tolerance in response
-        assert NEW_TYPO_TOLERANCE[typo_tolerance] == response[typo_tolerance]
+        assert typo_tolerance in response_get
+        assert NEW_TYPO_TOLERANCE[typo_tolerance] == response_get[typo_tolerance]
 
 def test_reset_typo_tolerance(empty_index):
     """Tests resetting the typo_tolerance setting to its default value."""
     index = empty_index()
 
-    # Update the settings first
-    response = index.update_typo_tolerance(NEW_TYPO_TOLERANCE)
-    update = index.wait_for_task(response['uid'])
-
-    assert update['status'] == 'succeeded'
-
-    # Check the settings have been correctly updated
-    response = index.get_typo_tolerance()
-
-    assert isinstance(response, dict)
+    # Update the settings
+    response_update = index.update_typo_tolerance(NEW_TYPO_TOLERANCE)
+    update1 = index.wait_for_task(response_update['uid'])
+    # Get the setting after update
+    response_get = index.get_typo_tolerance()
+    # Reset the setting
+    response_reset = index.reset_typo_tolerance()
+    update2 = index.wait_for_task(response_reset['uid'])
+    # Get the setting after reset
+    response_last = index.get_typo_tolerance()
+
+    assert update1['status'] == 'succeeded'
+    assert isinstance(response_get, dict)
     for typo_tolerance in NEW_TYPO_TOLERANCE:
-        assert typo_tolerance in response
-        assert NEW_TYPO_TOLERANCE[typo_tolerance] == response[typo_tolerance]
-
-    # Check the reset of the settings
-    response = index.reset_typo_tolerance()
-
-    assert isinstance(response, dict)
-    assert 'uid' in response
-
-    update = index.wait_for_task(response['uid'])
-
-    assert update['status'] == 'succeeded'
-
-    response = index.get_typo_tolerance()
-
-    assert response == DEFAULT_TYPO_TOLERANCE
+        assert typo_tolerance in response_get
+        assert NEW_TYPO_TOLERANCE[typo_tolerance] == response_get[typo_tolerance]
+    assert isinstance(response_reset, dict)
+    assert 'uid' in response_reset
+    assert update2['status'] == 'succeeded'
+    assert response_last == DEFAULT_TYPO_TOLERANCE