Skip to content

Commit d2cf8d9

Browse files
committed
Make key description optional
Fixes #1038
1 parent a43baec commit d2cf8d9

File tree

3 files changed

+31
-1
lines changed

3 files changed

+31
-1
lines changed

meilisearch/models/key.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
class _KeyBase(CamelBase):
1111
uid: str
1212
name: Optional[str] = None
13-
description: str
13+
description: Optional[str]
1414
actions: List[str]
1515
indexes: List[str]
1616
expires_at: Optional[datetime] = None

tests/client/test_client_key_meilisearch.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,15 @@ def test_create_keys_default(client, test_key_info):
4646
assert key.indexes == test_key_info["indexes"]
4747

4848

49+
def test_create_keys_without_desc(client, test_nondescript_key_info):
50+
"""Tests the creation of a key with no optional argument."""
51+
key = client.create_key(test_nondescript_key_info)
52+
print(key)
53+
54+
assert key.name == "keyWithoutDescription"
55+
assert key.description is None
56+
57+
4958
def test_create_keys_with_options(client, test_key_info):
5059
"""Tests the creation of a key with arguments."""
5160
key = client.create_key(

tests/conftest.py

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -206,6 +206,27 @@ def test_key_info(client):
206206
pass
207207

208208

209+
@fixture(scope="function")
210+
def test_nondescript_key_info(client):
211+
key_info = {
212+
"name": "keyWithoutDescription",
213+
"actions": ["search"],
214+
"indexes": [common.INDEX_UID],
215+
"expiresAt": None,
216+
}
217+
218+
yield key_info
219+
220+
try:
221+
keys = client.get_keys().results
222+
key = next(x for x in keys if x.name == key_info["name"])
223+
client.delete_key(key.key)
224+
except MeilisearchApiError:
225+
pass
226+
except StopIteration:
227+
pass
228+
229+
209230
@fixture(scope="function")
210231
def get_private_key(client):
211232
keys = client.get_keys().results

0 commit comments

Comments
 (0)