update tests

Author: nnethercott

meilisearch/index.py

@@ -25,14 +25,14 @@
 from meilisearch.errors import version_error_hint_message
 from meilisearch.models.document import Document, DocumentsResults
 from meilisearch.models.embedders import (
+    CompositeEmbedder,
     Embedders,
     EmbedderType,
     HuggingFaceEmbedder,
     OllamaEmbedder,
     OpenAiEmbedder,
     RestEmbedder,
     UserProvidedEmbedder,
-    CompositeEmbedder,
 )
 from meilisearch.models.index import (
     Faceting,

tests/settings/test_settings_embedders.py

@@ -1,11 +1,12 @@
 # pylint: disable=redefined-outer-name
 
 import pytest
+
 from meilisearch.models.embedders import (
+    CompositeEmbedder,
     HuggingFaceEmbedder,
     OpenAiEmbedder,
     UserProvidedEmbedder,
-    CompositeEmbedder,
 )
 
 
@@ -103,6 +104,7 @@ def test_huggingface_embedder_format(empty_index):
     assert embedders.embedders["huggingface"].distribution.mean == 0.5
     assert embedders.embedders["huggingface"].distribution.sigma == 0.1
     assert embedders.embedders["huggingface"].binary_quantized is False
+    assert embedders.embedders["huggingface"].pooling is False
 
 
 def test_ollama_embedder_format(empty_index):
@@ -196,28 +198,36 @@ def test_composite_embedder_format(empty_index):
     """Tests that CompositeEmbedder embedder has the required fields and proper format."""
     index = empty_index()
 
-    hf_default = HuggingFaceEmbedder().model_dump(by_alias=True, exclude_none=True)
+    embedder = HuggingFaceEmbedder().model_dump(by_alias=True, exclude_none=True)
 
     # create composite embedder
     composite_embedder = {
-        "default": {
+        "composite": {
             "source": "composite",
-            "searchEmbedder": hf_default,
-            "indexingEmbedder": hf_default,
+            "searchEmbedder": embedder,
+            "indexingEmbedder": embedder,
         }
     }
 
     response = index.update_embedders(composite_embedder)
-    index.wait_for_task(response.task_uid)
+    update = index.wait_for_task(response.task_uid)
     embedders = index.get_embedders()
-    print(embedders)
+    assert update.status == "succeeded"
+
     assert embedders.embedders["composite"].source == "composite"
 
+    # ensure serialization roundtrips nicely
     assert isinstance(embedders.embedders["composite"], CompositeEmbedder)
     assert isinstance(embedders.embedders["composite"].search_embedder, HuggingFaceEmbedder)
     assert isinstance(embedders.embedders["composite"].indexing_embedder, HuggingFaceEmbedder)
 
-    assert not hasattr(embedders.embedders["composite"].search_embedder, "document_template")
-    assert not hasattr(embedders.embedders["composite"].search_embedder, "document_template_max_bytes")
-    assert hasattr(embedders.embedders["composite"].indexing_embedder, "document_template")
-
+    # ensure search_embedder has no document_template
+    assert getattr(embedders.embedders["composite"].search_embedder, "document_template") is None
+    assert (
+        getattr(
+            embedders.embedders["composite"].search_embedder,
+            "document_template_max_bytes",
+        )
+        is None
+    )
+    assert getattr(embedders.embedders["composite"].indexing_embedder, "document_template")