Skip to content

Changes related to the next MeiliSearch release (v0.23.0) #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 12, 2021
Merged

Changes related to the next MeiliSearch release (v0.23.0) #327

merged 13 commits into from
Oct 12, 2021

Conversation

meili-bot
Copy link
Contributor

@meili-bot meili-bot commented Sep 29, 2021 •
edited by alallema
Loading

Related to this issue: meilisearch/integration-guides#142

This PR:

  • gathers the changes related to the next MeiliSearch release (v0.23.0) so that this package is ready when the official release is out.
  • should pass the tests against the latest pre-release of MeiliSearch.
  • might eventually contain test failures until the MeiliSearch v0.23.0 is out.

⚠️ This PR should NOT be merged until the next release of MeiliSearch (v0.23.0) is out.

This PR is auto-generated for the pre-release week purpose.

Done:

  • New format handling CSV NDJSON #329
    • Add new methods:
      • addDocumentsJson(string $documents, ?string $primaryKey = null)
      • addDocumentsNdJson(string $documents, ?string $primaryKey = null)
      • addDocumentsCsv(string $documents, ?string $primaryKey = null)
    • Add tests for new methods
    • Remove json header application/json for every http methods
  • Update code sample v0.23.0 #331

@curquiza curquiza added skip-changelog The PR will not appear in the release changelogs and removed skip-changelog The PR will not appear in the release changelogs labels Oct 4, 2021
@alallema alallema marked this pull request as ready for review October 11, 2021 09:14
curquiza
curquiza approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top moumoute

bidoubiwa
bidoubiwa approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥🔥🔥

@alallema
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Oct 12, 2021

Build succeeded:

@bors bors bot merged commit df74e09 into main Oct 12, 2021
@bors bors bot deleted the bump-meilisearch-v0.23.0 branch October 12, 2021 11:55
@alallema alallema added the skip-changelog The PR will not appear in the release changelogs label Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

@bidoubiwa bidoubiwa bidoubiwa approved these changes

Assignees
No one assigned
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@meili-bot @alallema @curquiza @bidoubiwa