Skip to content

Fix API key wording according to v0.25.0 of MeiliSearch #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2022
Merged

Fix API key wording according to v0.25.0 of MeiliSearch #401

merged 1 commit into from
Jan 18, 2022
+1 −1

Conversation

curquiza
Copy link
Member

Not a big deal, but we should remove the following wording

  • private key
  • public key

Indeed, since MeiliSearch v0.25.0, private key is replaced by admin key and public key by search key.

@curquiza curquiza added the skip-changelog The PR will not appear in the release changelogs label Jan 18, 2022
@curquiza curquiza requested a review from alallema January 18, 2022 16:35
alallema
alallema approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch and Thanks for this PR 🔥
LGTM! 🍔

@alallema
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 18, 2022

Build succeeded:

@bors bors bot merged commit 87278e2 into main Jan 18, 2022
@bors bors bot deleted the curquiza-patch-1 branch January 18, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alallema alallema alallema approved these changes

Assignees
No one assigned
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@curquiza @alallema