Skip to content

Made arg document_id to take both types str or int #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2022
Merged

Made arg document_id to take both types str or int #545

merged 2 commits into from
Oct 6, 2022

Conversation

sarvesh4396
Copy link

Pull Request

What does this PR do?

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sarvesh4396 for this PR and for contributing to Meilisearch ❤️
It seems there is an issue with typing in delete_documents according to mypy check

@sarvesh4396
Copy link
Author

This should fix it as http.post method accepts List[str] not List[str|int]

Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sarvesh4396 for this PR,
LGTM! 🎉
Thanks again for contributing with Meilisearch ❤️
If you are participating in Hacktoberfest, and you would like to receive some swag from Meilisearch too, please complete this form.

@alallema
Copy link
Contributor

alallema commented Oct 6, 2022

bors merge

@bors
Copy link
Contributor

bors bot commented Oct 6, 2022

@bors bors bot merged commit c104f2b into meilisearch:main Oct 6, 2022
@alallema
Copy link
Contributor

alallema commented Oct 6, 2022

This message is sent automatically

Thank you for contributing to Meilisearch. If you are participating in Hacktoberfest, and you would like to receive some gift from Meilisearch too, please complete this form.

@alallema alallema added enhancement New feature or request hacktoberfest labels Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] [Minor] Tweak get_ & delete_document method signature to take both type int or str
2 participants