Skip to content

New json handlers #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 18, 2022
Merged

New json handlers #562

merged 6 commits into from
Oct 18, 2022

Conversation

Ambareen09
Copy link
Contributor

@Ambareen09 Ambareen09 commented Oct 14, 2022

Pull Request

Related issue

Fixes #347

What does this PR do?

  • ...

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Ambareen09 and others added 2 commits October 14, 2022 23:50
This was co-authored by:

Co-Authored-By: Azanul Haque <[email protected]>
@alallema
Copy link
Contributor

Hello @Ambareen09,
Thank you very much for contributing to Meilisearch ❤️.
However, I am not available on the weekend, but I will be back on Monday 😊.

PS: This message was sent automatically!

@Ambareen09 Ambareen09 changed the title New ndjson handlers New json handlers Oct 14, 2022
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Ambareen09 for this PR!
I made some comments 😃
I see that it resumes #560 PR but this one was modified since I think that the best solution is to wait that this last one to be merged before merging yours or to remove the modifications of #560 but that will make failed the tests because update_documents_raw would not be available.

@Ambareen09
Copy link
Contributor Author

I'll wait for #560 to be merged, till then, I'll update my function according to your comment.

@Ambareen09 Ambareen09 requested a review from alallema October 17, 2022 12:27
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Ambareen09 for this PR! I update your branch it's work well
I forgot to ask can you remove the styling modification you made?

@Ambareen09 Ambareen09 requested a review from alallema October 18, 2022 12:18
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Ambareen09 for this PR!
LGTM! 🎉

@alallema
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Oct 18, 2022

Build succeeded:

@bors bors bot merged commit a39bacd into meilisearch:main Oct 18, 2022
@alallema
Copy link
Contributor

This message is sent automatically

Thanks again for contributing to Meilisearch ❤️
If you are participating in Hacktoberfest, and you would like to receive some gift from Meilisearch too, please complete this form.

@Ambareen09
Copy link
Contributor Author

Thank you!

@alallema alallema added enhancement New feature or request hacktoberfest labels Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NDJSON/CSV methods to add and update documents
2 participants