-
Notifications
You must be signed in to change notification settings - Fork 90
New json handlers #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New json handlers #562
Conversation
This was co-authored by: Co-Authored-By: Azanul Haque <[email protected]>
Co-Authored-By: Azanul Haque <[email protected]>
Hello @Ambareen09, PS: This message was sent automatically! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Ambareen09 for this PR!
I made some comments 😃
I see that it resumes #560 PR but this one was modified since I think that the best solution is to wait that this last one to be merged before merging yours or to remove the modifications of #560 but that will make failed the tests because update_documents_raw
would not be available.
I'll wait for #560 to be merged, till then, I'll update my function according to your comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Ambareen09 for this PR! I update your branch it's work well
I forgot to ask can you remove the styling modification you made?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Ambareen09 for this PR!
LGTM! 🎉
bors merge |
Build succeeded:
|
This message is sent automatically Thanks again for contributing to Meilisearch ❤️ |
Thank you! |
Pull Request
Related issue
Fixes #347
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!