Skip to content

Fix add_document behaviour with empty string #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 8, 2022
Merged

Conversation

adripo
Copy link
Contributor

@adripo adripo commented Oct 26, 2022

Pull Request

Related issue

Fixes #585

What does this PR do?

  • Receive a formal message for this case from Meilisearch API.
  • Test correct functionality

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@adripo adripo marked this pull request as ready for review October 26, 2022 21:21
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @adripo for this PR!
I made a few suggestions.
Don't hesitate to check the contribution I think you had some linting issues

@adripo
Copy link
Contributor Author

adripo commented Oct 27, 2022

Thanks @alallema. I followed your suggestions and fixed the lint issues.

@adripo
Copy link
Contributor Author

adripo commented Oct 30, 2022

@alallema can you please run the checks on my pr please?

Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @adripo for this PR!
LGTM! 🎉
Thanks again for contributing with Meilisearch ❤️
If you are participating in Hacktoberfest, and you would like to receive some swag from Meilisearch too, please complete this form.

alallema
alallema previously approved these changes Nov 8, 2022
@alallema
Copy link
Contributor

alallema commented Nov 8, 2022

bors merge

@bors
Copy link
Contributor

bors bot commented Nov 8, 2022

@bors bors bot merged commit 1246a36 into meilisearch:main Nov 8, 2022
@alallema alallema added the bug Something isn't working label Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add_document method doesn't give access to missing_payload error when empty string is send
2 participants