-
Notifications
You must be signed in to change notification settings - Fork 90
Fix add_document behaviour with empty string #586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @adripo for this PR!
I made a few suggestions.
Don't hesitate to check the contribution I think you had some linting issues
Thanks @alallema. I followed your suggestions and fixed the lint issues. |
@alallema can you please run the checks on my pr please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @adripo for this PR!
LGTM! 🎉
Thanks again for contributing with Meilisearch ❤️
If you are participating in Hacktoberfest, and you would like to receive some swag from Meilisearch too, please complete this form.
bors merge |
Pull Request
Related issue
Fixes #585
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!