Skip to content

Fix parameter name in docstring #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 4, 2023
Merged

Fix parameter name in docstring #673

merged 2 commits into from
Feb 4, 2023

Conversation

sanders41
Copy link
Collaborator

Pull Request

Related issue

N/A

What does this PR do?

  • Fixes the parameter name in the docstring

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@sanders41 sanders41 added the skip-changelog The PR will not appear in the release changelogs label Feb 4, 2023
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sanders41
Good catch LGTM 🎉

@alallema
Copy link
Contributor

alallema commented Feb 4, 2023

bors merge

bors bot added a commit that referenced this pull request Feb 4, 2023
673: Fix parameter name in docstring r=alallema a=sanders41

# Pull Request

## Related issue
N/A

## What does this PR do?
- Fixes the parameter name in the docstring

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: Paul Sanders <[email protected]>
@bors
Copy link
Contributor

bors bot commented Feb 4, 2023

Build failed:

@sanders41
Copy link
Collaborator Author

The failure here is the flaky test. A rerun should fix it.

@alallema
Copy link
Contributor

alallema commented Feb 4, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 4, 2023

@bors bors bot merged commit fa4532a into main Feb 4, 2023
@bors bors bot deleted the docstring-fix branch February 4, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants