Skip to content

Add method to use faceting sub routes #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2020

Conversation

curquiza
Copy link
Member

@curquiza curquiza commented Jun 3, 2020

NB: tests do not run yet because the v0.11 is not out.
If you want to run the tests with the last version of MeiliSearch, use cargo in the MeiliSearch repo, and go on my branch.

@curquiza curquiza marked this pull request as draft June 3, 2020 14:39
@curquiza curquiza requested a review from eskombro June 3, 2020 14:39
@curquiza curquiza marked this pull request as ready for review June 3, 2020 14:42
Copy link
Member

@eskombro eskombro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! I just added a suggestion to test in general 'attributes' routes with more than one element (several attributes), because you don't always have the same behavior than with a single one!

@curquiza curquiza force-pushed the add-facets-settings-routes branch from f0b00f7 to 742d033 Compare June 4, 2020 07:12
@curquiza
Copy link
Member Author

curquiza commented Jun 4, 2020

Changes done @eskombro
And now:
Capture d’écran 2020-06-04 à 09 36 46

@curquiza curquiza requested a review from eskombro June 4, 2020 07:37
Copy link
Member

@eskombro eskombro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@curquiza curquiza merged commit 0206ec6 into bump-meilisearch-v0.11 Jun 4, 2020
@curquiza curquiza deleted the add-facets-settings-routes branch June 4, 2020 09:10
curquiza added a commit that referenced this pull request Jun 9, 2020
curquiza added a commit that referenced this pull request Jun 15, 2020
* Upd version

* Add method to use faceting sub routes (#90)

* Remane apikey into api_key (#93)

* Implement faceting in search (#94)

* Implement faceting in search

* Upd test

* Clear all indexes before starting tests in a certain context (#95)

* Clear all indexes before starting tests in a certain context

* Update meilisearch/tests/__init__.py

Co-authored-by: Samuel Jimenez <[email protected]>

Co-authored-by: Samuel Jimenez <[email protected]>

* Upd version

* Add method to use faceting sub routes (#90)

* Remane apikey into api_key (#93)

* Implement faceting in search (#94)

* Implement faceting in search

* Upd test

* Fix parameter default value (#97)

* Add test with multiple facetFilters (#98)

* Change create_index prototype (#99)

* Change create_index prototype

* Update meilisearch/client.py

Co-authored-by: cvermand <[email protected]>

* Update meilisearch/index.py

Co-authored-by: cvermand <[email protected]>

Co-authored-by: cvermand <[email protected]>

Co-authored-by: Samuel Jimenez <[email protected]>
Co-authored-by: cvermand <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants