Merge #638

638: Remove in the next version non-exitant experimental feature r=irevoire a=CommanderStorm

# Pull Request

## Related issue
related to #637

## What does this PR do?
- Remove in the next version non-exitant experimental feature 

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: Frank Elsinga <[email protected]>

Author: meili-bors[bot]

.code-samples.meilisearch.yaml

@@ -1649,8 +1649,8 @@ get_experimental_features_1: |-
     .unwrap();
 update_experimental_features_1: |-
   let client = Client::new("http://localhost:7700", Some("apiKey"));
-  let mut features = ExperimentalFeatures::new(&client);
-  features.set_vector_store(true);
+  let features = ExperimentalFeatures::new(&client);
+  // update the feature you want here
   let res = features
     .update()
     .await

src/features.rs

@@ -8,9 +8,7 @@ use serde::{Deserialize, Serialize};
 /// Struct representing the experimental features result from the API.
 #[derive(Clone, Debug, Deserialize)]
 #[serde(rename_all = "camelCase")]
-pub struct ExperimentalFeaturesResult {
-    pub vector_store: bool,
-}
+pub struct ExperimentalFeaturesResult {}
 
 /// Struct representing the experimental features request.
 ///
@@ -24,29 +22,18 @@ pub struct ExperimentalFeaturesResult {
 /// # let MEILISEARCH_API_KEY = option_env!("MEILISEARCH_API_KEY").unwrap_or("masterKey");
 /// # let client = Client::new(MEILISEARCH_URL, Some(MEILISEARCH_API_KEY)).unwrap();
 /// let mut features = ExperimentalFeatures::new(&client);
-/// features.set_vector_store(true);
 /// ```
 #[derive(Debug, Serialize)]
 #[serde(rename_all = "camelCase")]
 pub struct ExperimentalFeatures<'a, Http: HttpClient> {
     #[serde(skip_serializing)]
     client: &'a Client<Http>,
-    #[serde(skip_serializing_if = "Option::is_none")]
-    pub vector_store: Option<bool>,
 }
 
 impl<'a, Http: HttpClient> ExperimentalFeatures<'a, Http> {
     #[must_use]
     pub fn new(client: &'a Client<Http>) -> Self {
-        ExperimentalFeatures {
-            client,
-            vector_store: None,
-        }
-    }
-
-    pub fn set_vector_store(&mut self, vector_store: bool) -> &mut Self {
-        self.vector_store = Some(vector_store);
-        self
+        ExperimentalFeatures { client }
     }
 
     /// Get all the experimental features
@@ -83,11 +70,10 @@ impl<'a, Http: HttpClient> ExperimentalFeatures<'a, Http> {
     /// # let MEILISEARCH_URL = option_env!("MEILISEARCH_URL").unwrap_or("http://localhost:7700");
     /// # let MEILISEARCH_API_KEY = option_env!("MEILISEARCH_API_KEY").unwrap_or("masterKey");
     /// # let client = Client::new(MEILISEARCH_URL, Some(MEILISEARCH_API_KEY)).unwrap();
-    /// tokio::runtime::Builder::new_current_thread().enable_all().build().unwrap().block_on(async {
-    ///     let mut features = ExperimentalFeatures::new(&client);
-    ///     features.set_vector_store(true);
-    ///     features.update().await.unwrap();
-    /// });
+    /// # tokio::runtime::Builder::new_current_thread().enable_all().build().unwrap().block_on(async {
+    /// let features = ExperimentalFeatures::new(&client);
+    /// features.update().await.unwrap();
+    /// # });
     /// ```
     pub async fn update(&self) -> Result<ExperimentalFeaturesResult, Error> {
         self.client
@@ -111,22 +97,11 @@ mod tests {
 
     #[meilisearch_test]
     async fn test_experimental_features_get(client: Client) {
-        let mut features = ExperimentalFeatures::new(&client);
-        features.set_vector_store(false);
+        let features = ExperimentalFeatures::new(&client);
+        // set feature here, once some exist again
         let _ = features.update().await.unwrap();
 
-        let res = features.get().await.unwrap();
-
-        assert!(!res.vector_store);
-    }
-
-    #[meilisearch_test]
-    async fn test_experimental_features_enable_vector_store(client: Client) {
-        let mut features = ExperimentalFeatures::new(&client);
-        features.set_vector_store(true);
-
-        let res = features.update().await.unwrap();
-
-        assert!(res.vector_store);
+        let _res = features.get().await.unwrap();
+        // assert that the feature has been set once they exist again
     }
 }

src/tenant_tokens.rs

@@ -29,7 +29,7 @@ pub fn generate_tenant_token(
         return Err(Error::InvalidUuid4Version);
     }
 
-    if expires_at.map_or(false, |expires_at| OffsetDateTime::now_utc() > expires_at) {
+    if expires_at.is_some_and(|expires_at| OffsetDateTime::now_utc() > expires_at) {
         return Err(Error::TenantTokensExpiredSignature);
     }