Skip to content

Update CI with the publishing of local meilisearch-index-setting-macro crate #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

bidoubiwa
Copy link
Contributor

This repository is using a local crate named meilisearch-index-setting-macro. It is required to be published to crates.io in order to be able to release the meilisearch crate

@bidoubiwa bidoubiwa requested a review from alallema December 21, 2022 11:23
@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label Dec 21, 2022
run: cargo build --release
- name: Build meilisearch crate
run: |-
cd meilisearch-index-setting-macro
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this name of directory? meilisearch-index-setting-macro

Copy link
Contributor Author

@bidoubiwa bidoubiwa Dec 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was set like that by the contributor that created the macro. You don't like it? Do you have any suggestion?

Copy link
Contributor

@alallema alallema Dec 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a suggestion but it's not really a clear name, no?

Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥

@bidoubiwa
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Dec 21, 2022

@bors bors bot merged commit e335b19 into main Dec 21, 2022
@bors bors bot deleted the update_CI_with_publishing_of_local_crate branch December 21, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants