Skip to content

Fix linting errors #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Fix linting errors #630

merged 1 commit into from
Jan 9, 2025

Conversation

Strift
Copy link
Contributor

@Strift Strift commented Jan 8, 2025

Pull Request

Attempts to fix linting errors from #629

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@Strift Strift requested a review from irevoire January 8, 2025 17:03
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

meili-bors bot added a commit that referenced this pull request Jan 9, 2025
629: Update installation instructions r=curquiza a=meili-bot

_This PR is auto-generated._

Update README.md with the latest installation instructions following this [mega issue](meilisearch/integration-guides#308).

630: Fix linting errors r=curquiza a=Strift

# Pull Request

Attempts to fix linting errors from #629 

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: meili-bot <[email protected]>
Co-authored-by: Strift <[email protected]>
Copy link
Contributor

meili-bors bot commented Jan 9, 2025

This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried.

Additional information:

{"message":"Changes must be made through a pull request.","documentation_url":"https://docs.github.com/articles/about-protected-branches","status":"422"}

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

meili-bors bot added a commit that referenced this pull request Jan 9, 2025
630: Fix linting errors r=curquiza a=Strift

# Pull Request

Attempts to fix linting errors from #629 

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: Strift <[email protected]>
Copy link
Contributor

meili-bors bot commented Jan 9, 2025

Build failed:

@curquiza
Copy link
Member

curquiza commented Jan 9, 2025

bors merge

Copy link
Contributor

meili-bors bot commented Jan 9, 2025

@meili-bors meili-bors bot merged commit 539535f into main Jan 9, 2025
7 checks passed
@meili-bors meili-bors bot deleted the chore/fix-linting-errors branch January 9, 2025 14:44
@curquiza curquiza added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Jan 9, 2025
meili-bors bot added a commit that referenced this pull request Feb 18, 2025
645: Update version for the next release (v0.28) r=Strift a=meili-bot

_This PR is auto-generated._

The automated script updates the version of meilisearch-rust to a new version: "v0.28"

👇 CHANGELOG

## ✨ New

- [AI-powered search](https://www.meilisearch.com/docs/learn/ai_powered_search/getting_started_with_ai_search) is now stable `@/Strift`

## 🚀 Enhancements

* Remove in the next version non-existent experimental feature (#638) `@/CommanderStorm`
* Add support for language settings and search parameter (#620) `@/necocen`
* Support reverse param in get_tasks (#633) `@/ellnix`
* Add `indices` to `MatchRange` (#632) `@/LukasKalbertodt`
* Changes related to the next Meilisearch release (v1.13) (#637) 

## ⚙️ Maintenance/misc

* Use resolver = "2" (#623) `@/dureuill`
* Fix linting errors (#630) `@/Strift`
* Fix broken links (#636) `@/ellnix`
* Fix separator token code samples (#640) `@/ellnix`
* Make doc-comments consistently be doc-comments (#639) `@/CommanderStorm`

Thanks again to `@/CommanderStorm,` `@/LukasKalbertodt,` `@/Strift,` `@/dureuill,` `@/ellnix,` and `@n/ecocen!` 🎉


Co-authored-by: meili-bot <[email protected]>
Co-authored-by: Laurent Cazanove <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants