remove temp-index-prefix option

Author: thislg

src/Command/MeilisearchImportCommand.php

@@ -81,13 +81,6 @@ protected function configure(): void
                 InputOption::VALUE_NONE,
                 'Import to temporary indices and use index swap to prevent downtime'
             )
-            ->addOption(
-                'temp-index-prefix',
-                null,
-                InputOption::VALUE_REQUIRED,
-                'Prefix for temporary indices',
-                self::TEMP_INDEX_PREFIX
-            )
         ;
     }
 
@@ -103,7 +96,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         $prefix = null;
 
         if ($swapIndices) {
-            $prefix = $input->getOption('temp-index-prefix') ?? self::TEMP_INDEX_PREFIX;
+            $prefix = self::TEMP_INDEX_PREFIX;
             $config['prefix'] = $prefix.($config['prefix'] ?? '');
         }
 

src/Services/SettingsUpdater.php

@@ -45,7 +45,7 @@ public function update(string $indice, ?int $responseTimeout = null, ?string $pr
             return;
         }
 
-        $indexName = $prefixedName ?: $index['prefixed_name'];
+        $indexName = $prefixedName ?? $index['prefixed_name'];
         $indexInstance = $this->searchClient->index($indexName);
         $responseTimeout = $responseTimeout ?? self::DEFAULT_RESPONSE_TIMEOUT;
 

tests/Integration/Command/MeilisearchImportCommandTest.php

@@ -406,36 +406,12 @@ public function testImportingIndexWithSwap(): void
 
         $output = $commandTester->getDisplay();
         $this->assertStringContainsString('Importing for index Meilisearch\Bundle\Tests\Entity\Post', $output);
-        $this->assertStringContainsString('Indexed a batch of '.$i.' / '.$i.' Meilisearch\Bundle\Tests\Entity\Post entities into _tmp_sf_phpunit__'.self::$indexName.' index ('.$i.' indexed since start)', $output);
+        $this->assertStringContainsString('Indexed a batch of 6 / 6 Meilisearch\Bundle\Tests\Entity\Post entities into _tmp_sf_phpunit__'.self::$indexName.' index ('.$i.' indexed since start)', $output);
         $this->assertStringContainsString('Swapping indices...', $output);
         $this->assertStringContainsString('Indices swapped.', $output);
         $this->assertStringContainsString('Deleting temporary indices...', $output);
         $this->assertStringContainsString('Deleted _tmp_sf_phpunit__'.self::$indexName, $output);
         $this->assertStringContainsString('Done!', $output);
         $this->assertSame(0, $return);
     }
-
-    public function testImportingIndexWithSwapAndTempIndexPrefix(): void
-    {
-        for ($i = 0; $i <= 5; ++$i) {
-            $this->createPost();
-        }
-
-        $command = $this->application->find('meilisearch:import');
-        $commandTester = new CommandTester($command);
-        $return = $commandTester->execute([
-            '--swap-indices' => true,
-            '--temp-index-prefix' => '_temp_prefix_',
-        ]);
-
-        $output = $commandTester->getDisplay();
-        $this->assertStringContainsString('Importing for index Meilisearch\Bundle\Tests\Entity\Post', $output);
-        $this->assertStringContainsString('Indexed a batch of '.$i.' / '.$i.' Meilisearch\Bundle\Tests\Entity\Post entities into _temp_prefix_sf_phpunit__'.self::$indexName.' index ('.$i.' indexed since start)', $output);
-        $this->assertStringContainsString('Swapping indices...', $output);
-        $this->assertStringContainsString('Indices swapped.', $output);
-        $this->assertStringContainsString('Deleting temporary indices...', $output);
-        $this->assertStringContainsString('Deleted _temp_prefix_sf_phpunit__'.self::$indexName, $output);
-        $this->assertStringContainsString('Done!', $output);
-        $this->assertSame(0, $return);
-    }
 }