Merge pull request #308 from norkunas/fix-nbResults

Fix using bundle configured `nbResults` for search

Author: brunoocasali

src/DependencyInjection/Configuration.php

@@ -22,10 +22,10 @@ public function getConfigTreeBuilder(): TreeBuilder
                 ->scalarNode('prefix')
                     ->defaultNull()
                 ->end()
-                ->scalarNode('nbResults')
+                ->integerNode('nbResults')
                     ->defaultValue(20)
                 ->end()
-                ->scalarNode('batchSize')
+                ->integerNode('batchSize')
                     ->defaultValue(500)
                 ->end()
                 ->arrayNode('doctrineSubscribedEvents')

src/Services/MeilisearchService.php

@@ -155,7 +155,7 @@ public function search(
     ): array {
         $this->assertIsSearchable($className);
 
-        $ids = $this->engine->search($query, $this->searchableAs($className), $searchParams);
+        $ids = $this->engine->search($query, $this->searchableAs($className), $searchParams + ['limit' => $this->configuration['nbResults']]);
         $results = [];
 
         // Check if the engine returns results in "hits" key

tests/Integration/SearchTest.php

@@ -10,7 +10,6 @@
 use Meilisearch\Bundle\Tests\Entity\Post;
 use Meilisearch\Bundle\Tests\Entity\Tag;
 use Meilisearch\Endpoints\Indexes;
-use Meilisearch\Exceptions\ApiException;
 use Symfony\Bundle\FrameworkBundle\Console\Application;
 use Symfony\Component\Console\Tester\CommandTester;
 
@@ -26,10 +25,6 @@ class SearchTest extends BaseKernelTestCase
     protected Application $application;
     protected Indexes $index;
 
-    /**
-     * @throws ApiException
-     * @throws \Exception
-     */
     protected function setUp(): void
     {
         parent::setUp();
@@ -115,8 +110,20 @@ public function testSearchPagination(): void
         $this->assertEqualsCanonicalizing(array_slice($testDataTitles, 2, 2), $resultTitles);
     }
 
-    protected function tearDown(): void
+    public function testSearchNbResults(): void
     {
-        parent::tearDown();
+        for ($i = 0; $i < 15; ++$i) {
+            $this->createPost();
+        }
+
+        $command = $this->application->find('meilisearch:import');
+        $commandTester = new CommandTester($command);
+        $commandTester->execute([
+            '--indices' => $this->index->getUid(),
+        ]);
+
+        $results = $this->searchService->search($this->objectManager, Post::class, 'test');
+
+        $this->assertCount(12, $results);
     }
 }