Skip to content

Tell the user that they must always enter 'bluetooth mode' to flash a micro:bit #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2019

Conversation

dnlbaines
Copy link

@dnlbaines dnlbaines commented Jun 7, 2019

This commit adds a new dialog that prompts the user to enter bluetooth mode when flashing the micro:bit if they have not done so already (and the hex they are using requires it). It also changes the samples.zip extraction to a much faster method.

Minor changes:

  • samples.zip was modified to remove an OS X folder
  • Updated the create code/my scripts buttons to link directly to makecode
  • Updated the bluetooth mode text based on a suggestion from @jaustin

@microbit-sam
Copy link

Hey Daniel,

Can you remind me of the steps required to trigger the warning you've added?

I thought we were catching the scenario where user has reflashed the micro:bit and hasn't repaired, but I've not managed to trigger your pop up.. flashing worked from 'makecode app' mode

@dnlbaines
Copy link
Author

dnlbaines commented Jun 11, 2019

Hey Daniel,

Can you remind me of the steps required to trigger the warning you've added?

I thought we were catching the scenario where user has reflashed the micro:bit and hasn't repaired, but I've not managed to trigger your pop up.. flashing worked from 'makecode app' mode

It should trigger if you have previously paired the micro:bit in the app but haven't entered bluetooth mode when you try to flash (and the hex is not one that does not require you to enter bluetooth mode).

@microbit-sam
Copy link

Right, so I think this also wants to cover when you try to connect to a micro:bit that you've flashed over USB since pairing

I've just tried USB flashing, pairing, USB flashing, then connecting in app mode
This fails with Error: Please reset your micro:bit and try again

In this situation the micro:bit needs to be re-paired, as the USB flash has removed the bond info that was stored in the flash

@microbit-sam microbit-sam self-requested a review June 17, 2019 13:38
@microbit-sam microbit-sam merged commit e32052a into microbit-foundation:master Jun 18, 2019
martinwork added a commit that referenced this pull request Mar 26, 2024
Version 3.0.4 (54) - Pairing - Add triple reset method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants