Skip to content

Update theme package #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2022
Merged

Update theme package #1076

merged 2 commits into from
Nov 21, 2022

Conversation

microbit-robert
Copy link
Collaborator

Utilise new container wrapper component to style the background color of the SideBarHeader component.
Use theme colors for the simulator compass icons.

@github-actions
Copy link

Preview build will be at
https://review-python-editor-v3.microbit.org/theme-fixes/

@microbit-robert
Copy link
Collaborator Author

Move from draft once https://github.com/microbit-foundation/python-editor-v3-microbit/pull/29 has been merged and the theme package has been updated.

@microbit-robert microbit-robert marked this pull request as ready for review November 21, 2022 15:33
Copy link
Collaborator

@microbit-matt-hillsdon microbit-matt-hillsdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@microbit-matt-hillsdon microbit-matt-hillsdon merged commit 0a0ba89 into main Nov 21, 2022
@microbit-matt-hillsdon microbit-matt-hillsdon deleted the theme-fixes branch November 21, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants