Skip to content

More reliable alert check #1111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2023
Merged

More reliable alert check #1111

merged 1 commit into from
Mar 4, 2023

Conversation

microbit-matt-hillsdon
Copy link
Collaborator

Closes #1110

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Preview build will be at
https://review-python-editor-v3.microbit.org/alert-fix/

@microbit-matt-hillsdon
Copy link
Collaborator Author

As I couldn't really reproduce locally we need to see this pass in CI a few times before merge.
I still occasionally see an unrelated failure in documentation.test.ts, but at least the open.test.ts cases should pass.

@microbit-matt-hillsdon microbit-matt-hillsdon merged commit f62af6b into main Mar 4, 2023
@microbit-matt-hillsdon microbit-matt-hillsdon deleted the alert-fix branch March 4, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky e2e test: open > Correctly handles an mpy file
1 participant