[Simulator] Initial data logging #922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview build will be at |
Still renders 40k times so we need to make further improvements.
It's literally an empty file which might cause confusion.
|
Odd hang in CI for a comment only change. Re-running. |
|
I have issues with the automatic scroll behaviour. It seems to work once and then never catches up? |
It stops sticking to the bottom if messages come faster than the speed of a smooth scroll. Not sure it's worth addressing that now.
Pushed a fix. It is still possible to break if messages come faster than the smooth scroll speed, but not addressing that for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.