Skip to content

Scale design to maximise available screen space #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Sep 15, 2022
Merged

Scale design to maximise available screen space #945

merged 20 commits into from
Sep 15, 2022

Conversation

microbit-robert
Copy link
Collaborator

No description provided.

@github-actions
Copy link

github-actions bot commented Sep 9, 2022

Preview build will be at
https://review-python-editor-next.microbit.org/percent-90/

microbit-robert
microbit-robert commented Sep 9, 2022
View reviewed changes
@microbit-robert
Copy link
Collaborator Author

Needs further work to ensure font sizes don't fall below a certain size threshold for readability. Spacing should also be reduced in some areas.

@microbit-matt-hillsdon
Copy link
Collaborator

I think we should seriously consider modifying the spacing scale and the font sizes in the theme before resorting to changing the root font size.

microbit-robert
microbit-robert commented Sep 13, 2022
View reviewed changes
@microbit-robert
Copy link
Collaborator Author

Sizes changes made to the default theme were originally made for testing purposes. Should they remain here or be removed?

@microbit-matt-hillsdon
Copy link
Collaborator

Sizes changes made to the default theme were originally made for testing purposes. Should they remain here or be removed?

I think we should probably make matching changes.

@microbit-robert
Copy link
Collaborator Author

Sizes changes made to the default theme were originally made for testing purposes. Should they remain here or be removed?

I think we should probably make matching changes.

Scaling changes to the default theme have been applied -> aedb570.

microbit-matt-hillsdon
microbit-matt-hillsdon approved these changes Sep 14, 2022
View reviewed changes
Copy link
Collaborator

@microbit-matt-hillsdon microbit-matt-hillsdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, subject to an updated theme package and final internal approval.

@microbit-robert microbit-robert marked this pull request as ready for review September 15, 2022 10:26
@microbit-robert microbit-robert changed the title Tweak design to match "90% view" Scale design to improve appearance when screen space is limited Sep 15, 2022
@microbit-robert microbit-robert changed the title Scale design to improve appearance when screen space is limited Scale design to maximise available screen space Sep 15, 2022
@microbit-robert microbit-robert merged commit 32739b2 into main Sep 15, 2022
@microbit-robert microbit-robert deleted the percent-90 branch September 15, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@microbit-matt-hillsdon microbit-matt-hillsdon microbit-matt-hillsdon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@microbit-robert @microbit-matt-hillsdon