Fix focus bugs that occur on initial load. #982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview build will be at |
|
|
||
| useEffect(() => { | ||
| if (shown) { | ||
| ref.current!.focus(); | ||
| // Prevents the simulator stealing focus on initial load. |
There was a problem hiding this comment.
I'd really love to find a way to move away from effects for this but I think this is a reasonable fix at this point.
| @@ -29,8 +29,9 @@ const SideBarTab = ({ | |||
| const ref = useRef<HTMLButtonElement>(null); | |||
| useEffect(() => { | |||
| // Override tabindex. | |||
| // Has no dependencies as it needs to run for every re-render. | |||
| ref.current!.setAttribute("tabindex", "0"); | |||
There was a problem hiding this comment.
Seems reasonable, though I'd love a world where we didn't have to hack this.
This was referenced Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some issues raised in #973 and #977.
The simulator and sidebar will no longer steal focus on load.
The sidebar tabs are always accessible, even if the sidebar loads in a collapsed state (screen widths <1366px).