Skip to content

Commit 33dc9a4

Browse files
committed
Change return type of window.open to Window | null (#18132)
1 parent 70fce49 commit 33dc9a4

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

baselines/dom.generated.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13277,7 +13277,7 @@ interface Window extends EventTarget, WindowTimers, WindowSessionStorage, Window
1327713277
moveBy(x?: number, y?: number): void;
1327813278
moveTo(x?: number, y?: number): void;
1327913279
msWriteProfilerMark(profilerMarkName: string): void;
13280-
open(url?: string, target?: string, features?: string, replace?: boolean): Window;
13280+
open(url?: string, target?: string, features?: string, replace?: boolean): Window | null;
1328113281
postMessage(message: any, targetOrigin: string, transfer?: any[]): void;
1328213282
print(): void;
1328313283
prompt(message?: string, _default?: string): string | null;
@@ -14677,7 +14677,7 @@ declare function matchMedia(mediaQuery: string): MediaQueryList;
1467714677
declare function moveBy(x?: number, y?: number): void;
1467814678
declare function moveTo(x?: number, y?: number): void;
1467914679
declare function msWriteProfilerMark(profilerMarkName: string): void;
14680-
declare function open(url?: string, target?: string, features?: string, replace?: boolean): Window;
14680+
declare function open(url?: string, target?: string, features?: string, replace?: boolean): Window | null;
1468114681
declare function postMessage(message: any, targetOrigin: string, transfer?: any[]): void;
1468214682
declare function print(): void;
1468314683
declare function prompt(message?: string, _default?: string): string | null;

inputfiles/overridingTypes.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -615,7 +615,7 @@
615615
"kind": "method",
616616
"interface": "Window",
617617
"name": "open",
618-
"signatures": ["open(url?: string, target?: string, features?: string, replace?: boolean): Window"]
618+
"signatures": ["open(url?: string, target?: string, features?: string, replace?: boolean): Window | null"]
619619
},
620620
{
621621
"kind": "method",

0 commit comments

Comments
 (0)