Skip to content

fix(dom): narrow ownerDocument in specific Node interfaces #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2020
Merged

fix(dom): narrow ownerDocument in specific Node interfaces #819

merged 1 commit into from
Mar 17, 2020

Conversation

eps1lon
Copy link
Contributor

@eps1lon eps1lon commented Jan 27, 2020

The ownerDocument attribute’s getter must return null, if this is a document, and this’s node document otherwise.

-- https://dom.spec.whatwg.org/#dom-node-ownerdocument

Closes microsoft/TypeScript#36262

@eps1lon eps1lon requested a review from sandersn as a code owner January 27, 2020 14:58
@eps1lon eps1lon mentioned this pull request Jan 27, 2020
Merged
sandersn
sandersn approved these changes Mar 17, 2020
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but needs a merge before we can take it. We ran out of time today so @eps1lon if you get to it before we do, ping me and I'll merge it.

@eps1lon eps1lon force-pushed the fix/owner-document-narrow branch from c030afa to d61aa19 Compare March 17, 2020 18:04
@eps1lon
Copy link
Contributor Author

eps1lon commented Mar 17, 2020

@sandersn Done.

@sandersn sandersn merged commit af44ea1 into microsoft:master Mar 17, 2020
@eps1lon eps1lon deleted the fix/owner-document-narrow branch March 17, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node.ownerDocument should not always be (Document | null)
2 participants
@eps1lon @sandersn