PR feedback

Author: weswigham

src/compiler/checker.ts

@@ -4123,15 +4123,15 @@ namespace ts {
                 if (context.tracker.trackSymbol && getCheckFlags(propertySymbol) & CheckFlags.Late) {
                     const decl = first(propertySymbol.declarations);
                     if (hasLateBindableName(decl)) {
-                        if (!isBinaryExpression(decl)) {
-                            trackComputedName(decl.name.expression, saveEnclosingDeclaration, context);
-                        }
-                        else {
+                        if (isBinaryExpression(decl)) {
                             const name = getNameOfDeclaration(decl);
                             if (name && isElementAccessExpression(name) && isPropertyAccessEntityNameExpression(name.argumentExpression)) {
                                 trackComputedName(name.argumentExpression, saveEnclosingDeclaration, context);
                             }
                         }
+                        else {
+                            trackComputedName(decl.name.expression, saveEnclosingDeclaration, context);
+                        }
                     }
                 }
                 const propertyName = symbolToName(propertySymbol, context, SymbolFlags.Value, /*expectsIdentifier*/ true);

src/compiler/utilities.ts

@@ -2074,7 +2074,10 @@ namespace ts {
         return AssignmentDeclarationKind.None;
     }
 
-    // TODO: Signed numeric literals?
+    /**
+     * Does not handle signed numeric names like `a[+0]` - handling those would require handling prefix unary expressions
+     * throughout late binding handling as well, which is awkward (but ultimately probably doable if there is demand)
+     */
     /* @internal */
     export function getElementOrPropertyAccessArgumentExpressionOrName(node: PropertyAccessExpression | ElementAccessExpression): Identifier | StringLiteralLike | NumericLiteral | ElementAccessExpression | undefined {
         if (isPropertyAccessExpression(node)) {