Unify symboles for template literals in computed properties

Author: IllusionMH

src/compiler/utilities.ts

@@ -2499,7 +2499,7 @@ namespace ts {
     }
 
     export function isLiteralComputedPropertyDeclarationName(node: Node) {
-        return (node.kind === SyntaxKind.StringLiteral || node.kind === SyntaxKind.NumericLiteral) &&
+        return isStringOrNumericLiteralLike(node) &&
             node.parent.kind === SyntaxKind.ComputedPropertyName &&
             isDeclaration(node.parent.parent);
     }

tests/baselines/reference/computedPropertyNames10_ES5.symbols

@@ -50,6 +50,7 @@ var v = {
 
     [`hello bye`]() { },
 >[`hello bye`] : Symbol([`hello bye`], Decl(computedPropertyNames10_ES5.ts, 12, 22))
+>`hello bye` : Symbol([`hello bye`], Decl(computedPropertyNames10_ES5.ts, 12, 22))
 
     [`hello ${a} bye`]() { }
 >[`hello ${a} bye`] : Symbol([`hello ${a} bye`], Decl(computedPropertyNames10_ES5.ts, 13, 24))

tests/baselines/reference/computedPropertyNames10_ES6.symbols

@@ -50,6 +50,7 @@ var v = {
 
     [`hello bye`]() { },
 >[`hello bye`] : Symbol([`hello bye`], Decl(computedPropertyNames10_ES6.ts, 12, 22))
+>`hello bye` : Symbol([`hello bye`], Decl(computedPropertyNames10_ES6.ts, 12, 22))
 
     [`hello ${a} bye`]() { }
 >[`hello ${a} bye`] : Symbol([`hello ${a} bye`], Decl(computedPropertyNames10_ES6.ts, 13, 24))

tests/baselines/reference/computedPropertyNames11_ES5.symbols

@@ -54,6 +54,7 @@ var v = {
 
     set [`hello bye`](v) { },
 >[`hello bye`] : Symbol([`hello bye`], Decl(computedPropertyNames11_ES5.ts, 12, 36))
+>`hello bye` : Symbol([`hello bye`], Decl(computedPropertyNames11_ES5.ts, 12, 36))
 >v : Symbol(v, Decl(computedPropertyNames11_ES5.ts, 13, 22))
 
     get [`hello ${a} bye`]() { return 0; }

tests/baselines/reference/computedPropertyNames11_ES6.symbols

@@ -54,6 +54,7 @@ var v = {
 
     set [`hello bye`](v) { },
 >[`hello bye`] : Symbol([`hello bye`], Decl(computedPropertyNames11_ES6.ts, 12, 36))
+>`hello bye` : Symbol([`hello bye`], Decl(computedPropertyNames11_ES6.ts, 12, 36))
 >v : Symbol(v, Decl(computedPropertyNames11_ES6.ts, 13, 22))
 
     get [`hello ${a} bye`]() { return 0; }

tests/baselines/reference/computedPropertyNames12_ES5.symbols

@@ -52,6 +52,7 @@ class C {
 
     [`hello bye`] = 0;
 >[`hello bye`] : Symbol(C[`hello bye`], Decl(computedPropertyNames12_ES5.ts, 12, 31))
+>`hello bye` : Symbol(C[`hello bye`], Decl(computedPropertyNames12_ES5.ts, 12, 31))
 
     static [`hello ${a} bye`] = 0
 >[`hello ${a} bye`] : Symbol(C[`hello ${a} bye`], Decl(computedPropertyNames12_ES5.ts, 13, 22))

tests/baselines/reference/computedPropertyNames12_ES6.symbols

@@ -52,6 +52,7 @@ class C {
 
     [`hello bye`] = 0;
 >[`hello bye`] : Symbol(C[`hello bye`], Decl(computedPropertyNames12_ES6.ts, 12, 31))
+>`hello bye` : Symbol(C[`hello bye`], Decl(computedPropertyNames12_ES6.ts, 12, 31))
 
     static [`hello ${a} bye`] = 0
 >[`hello ${a} bye`] : Symbol(C[`hello ${a} bye`], Decl(computedPropertyNames12_ES6.ts, 13, 22))

tests/baselines/reference/computedPropertyNames13_ES5.symbols

@@ -50,6 +50,7 @@ class C {
 
     [`hello bye`]() { }
 >[`hello bye`] : Symbol(C[`hello bye`], Decl(computedPropertyNames13_ES5.ts, 12, 28))
+>`hello bye` : Symbol(C[`hello bye`], Decl(computedPropertyNames13_ES5.ts, 12, 28))
 
     static [`hello ${a} bye`]() { }
 >[`hello ${a} bye`] : Symbol(C[`hello ${a} bye`], Decl(computedPropertyNames13_ES5.ts, 13, 23))

tests/baselines/reference/computedPropertyNames13_ES6.symbols

@@ -50,6 +50,7 @@ class C {
 
     [`hello bye`]() { }
 >[`hello bye`] : Symbol(C[`hello bye`], Decl(computedPropertyNames13_ES6.ts, 12, 28))
+>`hello bye` : Symbol(C[`hello bye`], Decl(computedPropertyNames13_ES6.ts, 12, 28))
 
     static [`hello ${a} bye`]() { }
 >[`hello ${a} bye`] : Symbol(C[`hello ${a} bye`], Decl(computedPropertyNames13_ES6.ts, 13, 23))

tests/baselines/reference/computedPropertyNames16_ES5.symbols

@@ -54,6 +54,7 @@ class C {
 
     set [`hello bye`](v) { }
 >[`hello bye`] : Symbol(C[`hello bye`], Decl(computedPropertyNames16_ES5.ts, 12, 42))
+>`hello bye` : Symbol(C[`hello bye`], Decl(computedPropertyNames16_ES5.ts, 12, 42))
 >v : Symbol(v, Decl(computedPropertyNames16_ES5.ts, 13, 22))
 
     get [`hello ${a} bye`]() { return 0; }

tests/baselines/reference/computedPropertyNames16_ES6.symbols

@@ -54,6 +54,7 @@ class C {
 
     set [`hello bye`](v) { }
 >[`hello bye`] : Symbol(C[`hello bye`], Decl(computedPropertyNames16_ES6.ts, 12, 42))
+>`hello bye` : Symbol(C[`hello bye`], Decl(computedPropertyNames16_ES6.ts, 12, 42))
 >v : Symbol(v, Decl(computedPropertyNames16_ES6.ts, 13, 22))
 
     get [`hello ${a} bye`]() { return 0; }

tests/baselines/reference/computedPropertyNames4_ES5.symbols

@@ -52,6 +52,7 @@ var v = {
 
     [`hello bye`]: 0,
 >[`hello bye`] : Symbol([`hello bye`], Decl(computedPropertyNames4_ES5.ts, 12, 19))
+>`hello bye` : Symbol([`hello bye`], Decl(computedPropertyNames4_ES5.ts, 12, 19))
 
     [`hello ${a} bye`]: 0
 >[`hello ${a} bye`] : Symbol([`hello ${a} bye`], Decl(computedPropertyNames4_ES5.ts, 13, 21))

tests/baselines/reference/computedPropertyNames4_ES6.symbols

@@ -52,6 +52,7 @@ var v = {
 
     [`hello bye`]: 0,
 >[`hello bye`] : Symbol([`hello bye`], Decl(computedPropertyNames4_ES6.ts, 12, 19))
+>`hello bye` : Symbol([`hello bye`], Decl(computedPropertyNames4_ES6.ts, 12, 19))
 
     [`hello ${a} bye`]: 0
 >[`hello ${a} bye`] : Symbol([`hello ${a} bye`], Decl(computedPropertyNames4_ES6.ts, 13, 21))

tests/baselines/reference/computerPropertiesInES5ShouldBeTransformed.symbols

@@ -1,6 +1,7 @@
 === tests/cases/compiler/computerPropertiesInES5ShouldBeTransformed.ts ===
 const b = ({ [`key`]: renamed }) => renamed;
 >b : Symbol(b, Decl(computerPropertiesInES5ShouldBeTransformed.ts, 0, 5))
+>`key` : Symbol(renamed, Decl(computerPropertiesInES5ShouldBeTransformed.ts, 0, 12))
 >renamed : Symbol(renamed, Decl(computerPropertiesInES5ShouldBeTransformed.ts, 0, 12))
 >renamed : Symbol(renamed, Decl(computerPropertiesInES5ShouldBeTransformed.ts, 0, 12))