fix(42923): add go-to-definition on unresolved shorthand properties

Author: a-tarasyuk

src/services/goToDefinition.ts

@@ -51,7 +51,9 @@ namespace ts.GoToDefinition {
         // assignment. This case and others are handled by the following code.
         if (node.parent.kind === SyntaxKind.ShorthandPropertyAssignment) {
             const shorthandSymbol = typeChecker.getShorthandAssignmentValueSymbol(symbol.valueDeclaration);
-            return shorthandSymbol ? shorthandSymbol.declarations.map(decl => createDefinitionInfo(decl, typeChecker, shorthandSymbol, node)) : [];
+            if (shorthandSymbol) {
+                return shorthandSymbol.declarations.map(decl => createDefinitionInfo(decl, typeChecker, shorthandSymbol, node));
+            }
         }
 
         // If the node is the name of a BindingElement within an ObjectBindingPattern instead of just returning the
@@ -91,6 +93,7 @@ namespace ts.GoToDefinition {
                 return flatMap(getPropertySymbolsFromContextualType(element, typeChecker, contextualType, /*unionSymbolOk*/ false), propertySymbol =>
                     getDefinitionFromSymbol(typeChecker, propertySymbol, node));
             }
+            return [];
         }
 
         return getDefinitionFromSymbol(typeChecker, symbol, node);

tests/cases/fourslash/goToDefinitionProperty1.ts

@@ -0,0 +1,11 @@
+/// <reference path="./fourslash.ts"/>
+
+////interface Foo {
+////    /*2*/foo(): void
+////}
+////
+////let x: Foo = {
+////    [|f/*1*/oo|]
+////}
+
+verify.goToDefinition("1", "2");

tests/cases/fourslash/goToDefinitionProperty2.ts

@@ -0,0 +1,11 @@
+/// <reference path="./fourslash.ts"/>
+
+////interface Foo {
+////    foo(): void
+////}
+////const /*2*/foo = 1;
+////let x: Foo = {
+////    [|f/*1*/oo|]
+////}
+
+verify.goToDefinition("1", "2");

tests/cases/fourslash/goToDefinitionProperty3.ts

@@ -0,0 +1,11 @@
+/// <reference path="./fourslash.ts"/>
+
+////interface Foo {
+////    /*2*/foo(): void
+////}
+////const foo = 1;
+////let x: Foo = {
+////    [|f/*1*/oo|]()
+////}
+
+verify.goToDefinition("1", "2");