Emit errors to octal escape sequences in template strings

Author: uhyo

src/compiler/diagnosticMessages.json

@@ -1196,6 +1196,10 @@
         "category": "Error",
         "code": 1391
     },
+    "Octal escape sequences are not allowed in template strings.": {
+        "category": "Error",
+        "code": 1392
+    },
     "The types of '{0}' are incompatible between these types.": {
         "category": "Error",
         "code": 2200

src/compiler/parser.ts

@@ -2582,7 +2582,6 @@ namespace ts {
 
         function parseTemplateExpression(isTaggedTemplate: boolean, containsInvalidEscape: boolean): TemplateExpression {
             const pos = getNodePos();
-            console.log({ isTaggedTemplate, containsInvalidEscape });
             return finishNode(
                 factory.createTemplateExpression(
                     parseTemplateHead(isTaggedTemplate, containsInvalidEscape),

src/compiler/scanner.ts

@@ -1309,6 +1309,9 @@ namespace ts {
                             pos++;
                             return text.substring(start, pos);
                         }
+                        if (shouldEmitInvalidEscapeError) {
+                            error(Diagnostics.Octal_escape_sequences_are_not_allowed_in_template_strings);
+                        }
                     }
                     return "\0";
                 case CharacterCodes.b:

tests/baselines/reference/templateLiteralInvalidEscape.errors.txt

@@ -2,13 +2,15 @@ tests/cases/compiler/templateLiteralInvalidEscape.ts(11,4): error TS1125: Hexade
 tests/cases/compiler/templateLiteralInvalidEscape.ts(12,5): error TS1125: Hexadecimal digit expected.
 tests/cases/compiler/templateLiteralInvalidEscape.ts(13,6): error TS1125: Hexadecimal digit expected.
 tests/cases/compiler/templateLiteralInvalidEscape.ts(14,5): error TS1125: Hexadecimal digit expected.
+tests/cases/compiler/templateLiteralInvalidEscape.ts(15,4): error TS1392: Octal escape sequences are not allowed in template strings.
 tests/cases/compiler/templateLiteralInvalidEscape.ts(23,8): error TS1125: Hexadecimal digit expected.
 tests/cases/compiler/templateLiteralInvalidEscape.ts(24,9): error TS1125: Hexadecimal digit expected.
 tests/cases/compiler/templateLiteralInvalidEscape.ts(25,10): error TS1125: Hexadecimal digit expected.
 tests/cases/compiler/templateLiteralInvalidEscape.ts(26,9): error TS1125: Hexadecimal digit expected.
+tests/cases/compiler/templateLiteralInvalidEscape.ts(27,8): error TS1392: Octal escape sequences are not allowed in template strings.
 
 
-==== tests/cases/compiler/templateLiteralInvalidEscape.ts (8 errors) ====
+==== tests/cases/compiler/templateLiteralInvalidEscape.ts (10 errors) ====
     function raw(arr: TemplateStringsArray, ...args: unknown[]) {
       return arr.raw;
     }
@@ -32,6 +34,8 @@ tests/cases/compiler/templateLiteralInvalidEscape.ts(26,9): error TS1125: Hexade
 
 !!! error TS1125: Hexadecimal digit expected.
     `\0123`;
+       
+!!! error TS1392: Octal escape sequences are not allowed in template strings.
 
     raw`${0}\x`;
     raw`${0}\x0`;
@@ -52,4 +56,6 @@ tests/cases/compiler/templateLiteralInvalidEscape.ts(26,9): error TS1125: Hexade
 
 !!! error TS1125: Hexadecimal digit expected.
     `${0}\0123`;
+           
+!!! error TS1392: Octal escape sequences are not allowed in template strings.