Skip to content

Commit 9ed608b

Browse files
authored
fix(41244): ignore synthesized imports (#41267)
1 parent c923023 commit 9ed608b

File tree

3 files changed

+35
-1
lines changed

3 files changed

+35
-1
lines changed

src/services/utilities.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1827,7 +1827,9 @@ namespace ts {
18271827
return preferences.quotePreference === "single" ? QuotePreference.Single : QuotePreference.Double;
18281828
}
18291829
else {
1830-
const firstModuleSpecifier = sourceFile.imports && find(sourceFile.imports, isStringLiteral);
1830+
// ignore synthetic import added when importHelpers: true
1831+
const firstModuleSpecifier = sourceFile.imports &&
1832+
find(sourceFile.imports, n => isStringLiteral(n) && !nodeIsSynthesized(n.parent)) as StringLiteral;
18311833
return firstModuleSpecifier ? quotePreferenceFromString(firstModuleSpecifier, sourceFile) : QuotePreference.Double;
18321834
}
18331835
}
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
/// <reference path='fourslash.ts'/>
2+
3+
// @importHelpers: true
4+
// @filename: /a.ts
5+
////export default () => {};
6+
7+
// @filename: /b.ts
8+
////export default () => {};
9+
10+
// @filename: /test.ts
11+
////import a from "./a";
12+
////[|b|];
13+
14+
goTo.file("/test.ts");
15+
verify.importFixAtPosition([`import b from "./b";
16+
b`]);
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
/// <reference path='fourslash.ts'/>
2+
3+
// @importHelpers: true
4+
// @filename: /a.ts
5+
////export default () => {};
6+
7+
// @filename: /b.ts
8+
////export default () => {};
9+
10+
// @filename: /test.ts
11+
////import a from './a';
12+
////[|b|];
13+
14+
goTo.file("/test.ts");
15+
verify.importFixAtPosition([`import b from './b';
16+
b`]);

0 commit comments

Comments
 (0)