Just use notImplemented

Andy Hanson · Andy Hanson · commit ca970063a396 · 2016-10-20T07:15:25.000-07:00
diff --git a/src/compiler/core.ts b/src/compiler/core.ts
@@ -872,16 +872,11 @@ namespace ts {
     /** Does nothing. */
     export function noop(): void {}
 
-    /** A function not intended to be implemented. */
+    /** Throws an error because a function is not implemented. */
     export function notImplemented(): never {
         throw new Error("Not implemented");
     }
 
-    /** A function which isn't implemented, but should be eventually. */
-    export function notYetImplemented(): never {
-        throw new Error("TODO: Not yet implemented");
-    }
-
     export function memoize<T>(callback: () => T): () => T {
         let value: T;
         return () => {
diff --git a/src/harness/harness.ts b/src/harness/harness.ts
@@ -1668,7 +1668,7 @@ namespace Harness {
         // This does not need to exist strictly speaking, but many tests will need to be updated if it's removed
         export function compileString(_code: string, _unitName: string, _callback: (result: CompilerResult) => void) {
             // NEWTODO: Re-implement 'compileString'
-            return ts.notYetImplemented();
+            return ts.notImplemented();
         }
 
         export interface GeneratedFile {
diff --git a/src/harness/harnessLanguageService.ts b/src/harness/harnessLanguageService.ts
@@ -313,7 +313,7 @@ namespace Harness.LanguageService {
         getLocalizedDiagnosticMessages(): string { return JSON.stringify({}); }
 
         readDirectory(_rootDir: string, _extension: string): string {
-            return ts.notYetImplemented();
+            return ts.notImplemented();
         }
         readDirectoryNames = ts.notImplemented;
         readFileNames = ts.notImplemented;
@@ -335,7 +335,7 @@ namespace Harness.LanguageService {
         constructor(private shim: ts.ClassifierShim) {
         }
         getEncodedLexicalClassifications(_text: string, _lexState: ts.EndOfLineState, _classifyKeywordsInGenerics?: boolean): ts.Classifications {
-            return ts.notYetImplemented();
+            return ts.notImplemented();
         }
         getClassificationsForLine(text: string, lexState: ts.EndOfLineState, classifyKeywordsInGenerics?: boolean): ts.ClassificationResult {
             const result = this.shim.getClassificationsForLine(text, lexState, classifyKeywordsInGenerics).split("\n");
@@ -644,7 +644,7 @@ namespace Harness.LanguageService {
         }
 
         createDirectory(_directoryName: string): void {
-            return ts.notYetImplemented();
+            return ts.notImplemented();
         }
 
         getCurrentDirectory(): string {
@@ -660,7 +660,7 @@ namespace Harness.LanguageService {
         }
 
         readDirectory(_path: string, _extension?: string[], _exclude?: string[], _include?: string[]): string[] {
-            return ts.notYetImplemented();
+            return ts.notImplemented();
         }
 
         watchFile(): ts.FileWatcher {
diff --git a/src/harness/unittests/cachingInServerLSHost.ts b/src/harness/unittests/cachingInServerLSHost.ts
@@ -26,10 +26,10 @@ namespace ts {
                 return path in fileMap ? fileMap[path].content : undefined;
             },
             writeFile: (_path: string, _data: string, _writeByteOrderMark?: boolean) => {
-                return ts.notYetImplemented();
+                return ts.notImplemented();
             },
             resolvePath: (_path: string): string => {
-                return ts.notYetImplemented();
+                return ts.notImplemented();
             },
             fileExists: (path: string): boolean => {
                 return path in fileMap;
@@ -47,7 +47,7 @@ namespace ts {
             getDirectories: () => [],
             getEnvironmentVariable: () => "",
             readDirectory: (_path: string, _extension?: string[], _exclude?: string[], _include?: string[]): string[] => {
-                return ts.notYetImplemented();
+                return ts.notImplemented();
             },
             exit: noop,
             watchFile: () => ({
diff --git a/src/harness/unittests/reuseProgramStructure.ts b/src/harness/unittests/reuseProgramStructure.ts
@@ -111,7 +111,7 @@ namespace ts {
             getDefaultLibFileName(): string {
                 return "lib.d.ts";
             },
-            writeFile: notYetImplemented,
+            writeFile: notImplemented,
             getCurrentDirectory(): string {
                 return "";
             },
diff --git a/src/harness/unittests/tsserverProjectSystem.ts b/src/harness/unittests/tsserverProjectSystem.ts
@@ -521,8 +521,8 @@ namespace ts.projectSystem {
         readonly resolvePath = (s: string) => s;
         readonly getExecutingFilePath = () => this.executingFilePath;
         readonly getCurrentDirectory = () => this.currentDirectory;
-        readonly exit = notYetImplemented;
-        readonly getEnvironmentVariable = notYetImplemented;
+        readonly exit = notImplemented;
+        readonly getEnvironmentVariable = notImplemented;
     }
 
     export function makeSessionRequest<T>(command: string, args: T) {
diff --git a/src/server/client.ts b/src/server/client.ts
@@ -242,7 +242,7 @@ namespace ts.server {
         }
 
         getCompletionEntrySymbol(_fileName: string, _position: number, _entryName: string): Symbol {
-            return notYetImplemented();
+            return notImplemented();
         }
 
         getNavigateToItems(searchValue: string): NavigateToItem[] {
@@ -415,7 +415,7 @@ namespace ts.server {
         }
 
         getEmitOutput(_fileName: string): EmitOutput {
-            return notYetImplemented();
+            return notImplemented();
         }
 
         getSyntacticDiagnostics(fileName: string): Diagnostic[] {
@@ -457,7 +457,7 @@ namespace ts.server {
         }
 
         getCompilerOptionsDiagnostics(): Diagnostic[] {
-            return notYetImplemented();
+            return notImplemented();
         }
 
         getRenameInfo(fileName: string, position: number, findInStrings?: boolean, findInComments?: boolean): RenameInfo {
@@ -562,11 +562,11 @@ namespace ts.server {
         }
 
         getNameOrDottedNameSpan(_fileName: string, _startPos: number, _endPos: number): TextSpan {
-            return notYetImplemented();
+            return notImplemented();
         }
 
         getBreakpointStatementAtPosition(_fileName: string, _position: number): TextSpan {
-            return notYetImplemented();
+            return notImplemented();
         }
 
         getSignatureHelpItems(fileName: string, position: number): SignatureHelpItems {
@@ -656,19 +656,19 @@ namespace ts.server {
         }
 
         getOutliningSpans(_fileName: string): OutliningSpan[] {
-            return notYetImplemented();
+            return notImplemented();
         }
 
         getTodoComments(_fileName: string, _descriptors: TodoCommentDescriptor[]): TodoComment[] {
-            return notYetImplemented();
+            return notImplemented();
         }
 
         getDocCommentTemplateAtPosition(_fileName: string, _position: number): TextInsertion {
-            return notYetImplemented();
+            return notImplemented();
         }
 
         isValidBraceCompletionAtPosition(_fileName: string, _position: number, _openingBrace: number): boolean {
-            return notYetImplemented();
+            return notImplemented();
         }
 
         getCodeFixesAtPosition(fileName: string, start: number, end: number, errorCodes: number[]): CodeAction[] {
@@ -735,23 +735,23 @@ namespace ts.server {
         }
 
         getIndentationAtPosition(_fileName: string, _position: number, _options: EditorOptions): number {
-            return notYetImplemented();
+            return notImplemented();
         }
 
         getSyntacticClassifications(_fileName: string, _span: TextSpan): ClassifiedSpan[] {
-            return notYetImplemented();
+            return notImplemented();
         }
 
         getSemanticClassifications(_fileName: string, _span: TextSpan): ClassifiedSpan[] {
-            return notYetImplemented();
+            return notImplemented();
         }
 
         getEncodedSyntacticClassifications(_fileName: string, _span: TextSpan): Classifications {
-            return notYetImplemented();
+            return notImplemented();
         }
 
         getEncodedSemanticClassifications(_fileName: string, _span: TextSpan): Classifications {
-            return notYetImplemented();
+            return notImplemented();
         }
 
         getProgram(): Program {

Original file line number	Diff line number	Diff line change
`@@ -1668,7 +1668,7 @@ namespace Harness {`
`1668`	`1668`	`// This does not need to exist strictly speaking, but many tests will need to be updated if it's removed`
`1669`	`1669`	`export function compileString(_code: string, _unitName: string, _callback: (result: CompilerResult) => void) {`
`1670`	`1670`	`// NEWTODO: Re-implement 'compileString'`
`1671`		`- return ts.notYetImplemented();`
	`1671`	`+ return ts.notImplemented();`
`1672`	`1672`	`}`
`1673`	`1673`
`1674`	`1674`	`export interface GeneratedFile {`
Original file line number	Diff line number	Diff line change
`@@ -313,7 +313,7 @@ namespace Harness.LanguageService {`
`313`	`313`	`getLocalizedDiagnosticMessages(): string { return JSON.stringify({}); }`
`314`	`314`
`315`	`315`	`readDirectory(_rootDir: string, _extension: string): string {`
`316`		`- return ts.notYetImplemented();`
	`316`	`+ return ts.notImplemented();`
`317`	`317`	`}`
`318`	`318`	`readDirectoryNames = ts.notImplemented;`
`319`	`319`	`readFileNames = ts.notImplemented;`
`@@ -335,7 +335,7 @@ namespace Harness.LanguageService {`
`335`	`335`	`constructor(private shim: ts.ClassifierShim) {`
`336`	`336`	`}`
`337`	`337`	`getEncodedLexicalClassifications(_text: string, _lexState: ts.EndOfLineState, _classifyKeywordsInGenerics?: boolean): ts.Classifications {`
`338`		`- return ts.notYetImplemented();`
	`338`	`+ return ts.notImplemented();`
`339`	`339`	`}`
`340`	`340`	`getClassificationsForLine(text: string, lexState: ts.EndOfLineState, classifyKeywordsInGenerics?: boolean): ts.ClassificationResult {`
`341`	`341`	`const result = this.shim.getClassificationsForLine(text, lexState, classifyKeywordsInGenerics).split("\n");`
`@@ -644,7 +644,7 @@ namespace Harness.LanguageService {`
`644`	`644`	`}`
`645`	`645`
`646`	`646`	`createDirectory(_directoryName: string): void {`
`647`		`- return ts.notYetImplemented();`
	`647`	`+ return ts.notImplemented();`
`648`	`648`	`}`
`649`	`649`
`650`	`650`	`getCurrentDirectory(): string {`
`@@ -660,7 +660,7 @@ namespace Harness.LanguageService {`
`660`	`660`	`}`
`661`	`661`
`662`	`662`	`readDirectory(_path: string, _extension?: string[], _exclude?: string[], _include?: string[]): string[] {`
`663`		`- return ts.notYetImplemented();`
	`663`	`+ return ts.notImplemented();`
`664`	`664`	`}`
`665`	`665`
`666`	`666`	`watchFile(): ts.FileWatcher {`
Original file line number	Diff line number	Diff line change
`@@ -242,7 +242,7 @@ namespace ts.server {`
`242`	`242`	`}`
`243`	`243`
`244`	`244`	`getCompletionEntrySymbol(_fileName: string, _position: number, _entryName: string): Symbol {`
`245`		`- return notYetImplemented();`
	`245`	`+ return notImplemented();`
`246`	`246`	`}`
`247`	`247`
`248`	`248`	`getNavigateToItems(searchValue: string): NavigateToItem[] {`
`@@ -415,7 +415,7 @@ namespace ts.server {`
`415`	`415`	`}`
`416`	`416`
`417`	`417`	`getEmitOutput(_fileName: string): EmitOutput {`
`418`		`- return notYetImplemented();`
	`418`	`+ return notImplemented();`
`419`	`419`	`}`
`420`	`420`
`421`	`421`	`getSyntacticDiagnostics(fileName: string): Diagnostic[] {`
`@@ -457,7 +457,7 @@ namespace ts.server {`
`457`	`457`	`}`
`458`	`458`
`459`	`459`	`getCompilerOptionsDiagnostics(): Diagnostic[] {`
`460`		`- return notYetImplemented();`
	`460`	`+ return notImplemented();`
`461`	`461`	`}`
`462`	`462`
`463`	`463`	`getRenameInfo(fileName: string, position: number, findInStrings?: boolean, findInComments?: boolean): RenameInfo {`
`@@ -562,11 +562,11 @@ namespace ts.server {`
`562`	`562`	`}`
`563`	`563`
`564`	`564`	`getNameOrDottedNameSpan(_fileName: string, _startPos: number, _endPos: number): TextSpan {`
`565`		`- return notYetImplemented();`
	`565`	`+ return notImplemented();`
`566`	`566`	`}`
`567`	`567`
`568`	`568`	`getBreakpointStatementAtPosition(_fileName: string, _position: number): TextSpan {`
`569`		`- return notYetImplemented();`
	`569`	`+ return notImplemented();`
`570`	`570`	`}`
`571`	`571`
`572`	`572`	`getSignatureHelpItems(fileName: string, position: number): SignatureHelpItems {`
`@@ -656,19 +656,19 @@ namespace ts.server {`
`656`	`656`	`}`
`657`	`657`
`658`	`658`	`getOutliningSpans(_fileName: string): OutliningSpan[] {`
`659`		`- return notYetImplemented();`
	`659`	`+ return notImplemented();`
`660`	`660`	`}`
`661`	`661`
`662`	`662`	`getTodoComments(_fileName: string, _descriptors: TodoCommentDescriptor[]): TodoComment[] {`
`663`		`- return notYetImplemented();`
	`663`	`+ return notImplemented();`
`664`	`664`	`}`
`665`	`665`
`666`	`666`	`getDocCommentTemplateAtPosition(_fileName: string, _position: number): TextInsertion {`
`667`		`- return notYetImplemented();`
	`667`	`+ return notImplemented();`
`668`	`668`	`}`
`669`	`669`
`670`	`670`	`isValidBraceCompletionAtPosition(_fileName: string, _position: number, _openingBrace: number): boolean {`
`671`		`- return notYetImplemented();`
	`671`	`+ return notImplemented();`
`672`	`672`	`}`
`673`	`673`
`674`	`674`	`getCodeFixesAtPosition(fileName: string, start: number, end: number, errorCodes: number[]): CodeAction[] {`
`@@ -735,23 +735,23 @@ namespace ts.server {`
`735`	`735`	`}`
`736`	`736`
`737`	`737`	`getIndentationAtPosition(_fileName: string, _position: number, _options: EditorOptions): number {`
`738`		`- return notYetImplemented();`
	`738`	`+ return notImplemented();`
`739`	`739`	`}`
`740`	`740`
`741`	`741`	`getSyntacticClassifications(_fileName: string, _span: TextSpan): ClassifiedSpan[] {`
`742`		`- return notYetImplemented();`
	`742`	`+ return notImplemented();`
`743`	`743`	`}`
`744`	`744`
`745`	`745`	`getSemanticClassifications(_fileName: string, _span: TextSpan): ClassifiedSpan[] {`
`746`		`- return notYetImplemented();`
	`746`	`+ return notImplemented();`
`747`	`747`	`}`
`748`	`748`
`749`	`749`	`getEncodedSyntacticClassifications(_fileName: string, _span: TextSpan): Classifications {`
`750`		`- return notYetImplemented();`
	`750`	`+ return notImplemented();`
`751`	`751`	`}`
`752`	`752`
`753`	`753`	`getEncodedSemanticClassifications(_fileName: string, _span: TextSpan): Classifications {`
`754`		`- return notYetImplemented();`
	`754`	`+ return notImplemented();`
`755`	`755`	`}`
`756`	`756`
`757`	`757`	`getProgram(): Program {`