skip all d.ts, not just node_modules/lib

sandersn · sandersn · commit cfea6e154368 · 2021-07-15T09:01:49.000-07:00
diff --git a/src/services/codefixes/addOptionalPropertyUndefined.ts b/src/services/codefixes/addOptionalPropertyUndefined.ts
@@ -48,7 +48,7 @@ namespace ts.codefix {
         }
         const { source: sourceNode, target: targetNode } = sourceTarget;
         const target = checker.getTypeAtLocation(targetNode);
-        if (target.symbol?.declarations?.some(d => getSourceFileOfNode(d).fileName.match(/(node_modules|^lib\.)/))) {
+        if (target.symbol?.declarations?.some(d => getSourceFileOfNode(d).fileName.match(/\.d\.ts$/))) {
             return [];
         }
         return checker.getExactOptionalUnassignableProperties(checker.getTypeAtLocation(sourceNode), target);

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ namespace ts.codefix {`
`48`	`48`	`}`
`49`	`49`	`const { source: sourceNode, target: targetNode } = sourceTarget;`
`50`	`50`	`const target = checker.getTypeAtLocation(targetNode);`
`51`		`- if (target.symbol?.declarations?.some(d => getSourceFileOfNode(d).fileName.match(/(node_modules\|^lib\.)/))) {`
	`51`	`+ if (target.symbol?.declarations?.some(d => getSourceFileOfNode(d).fileName.match(/\.d\.ts$/))) {`
`52`	`52`	`return [];`
`53`	`53`	`}`
`54`	`54`	`return checker.getExactOptionalUnassignableProperties(checker.getTypeAtLocation(sourceNode), target);`