Always call getCandidateForOverloadFailure

Author: Andy Hanson

src/compiler/checker.ts

@@ -19184,7 +19184,7 @@ namespace ts {
                 diagnostics.add(createDiagnosticForNode(node, fallbackError));
             }
 
-            return produceDiagnostics || !args ? resolveErrorCall(node) : getCandidateForOverloadFailure(node, candidates, args, !!candidatesOutArray);
+            return getCandidateForOverloadFailure(node, candidates, args, !!candidatesOutArray);
 
             function chooseOverload(candidates: Signature[], relation: Map<RelationComparisonResult>, signatureHelpTrailingComma = false) {
                 candidateForArgumentError = undefined;

tests/baselines/reference/argumentExpressionContextualTyping.types

@@ -122,7 +122,7 @@ baz(array);                          // Error
 baz(["string", 1, true, ...array]);  // Error
 >baz(["string", 1, true, ...array]) : void
 >baz : (x: [string, number, boolean]) => void
->["string", 1, true, ...array] : (string | number | boolean)[]
+>["string", 1, true, ...array] : [string, number, true, ...(string | number | boolean)[]]
 >"string" : "string"
 >1 : 1
 >true : true

tests/baselines/reference/arrayAssignmentTest3.types

@@ -17,8 +17,8 @@ class a {
 
 
 var xx = new a(null, 7, new B());
->xx : any
->new a(null, 7, new B()) : any
+>xx : a
+>new a(null, 7, new B()) : a
 >a : typeof a
 >null : null
 >7 : 7

tests/baselines/reference/baseCheck.errors.txt

@@ -1,15 +1,13 @@
 tests/cases/compiler/baseCheck.ts(9,18): error TS2552: Cannot find name 'loc'. Did you mean 'ELoc'?
 tests/cases/compiler/baseCheck.ts(17,53): error TS2554: Expected 2 arguments, but got 1.
-tests/cases/compiler/baseCheck.ts(17,59): error TS17009: 'super' must be called before accessing 'this' in the constructor of a derived class.
 tests/cases/compiler/baseCheck.ts(18,62): error TS17009: 'super' must be called before accessing 'this' in the constructor of a derived class.
 tests/cases/compiler/baseCheck.ts(19,59): error TS2345: Argument of type '"hello"' is not assignable to parameter of type 'number'.
-tests/cases/compiler/baseCheck.ts(19,68): error TS17009: 'super' must be called before accessing 'this' in the constructor of a derived class.
 tests/cases/compiler/baseCheck.ts(22,9): error TS2304: Cannot find name 'x'.
 tests/cases/compiler/baseCheck.ts(23,7): error TS2304: Cannot find name 'x'.
 tests/cases/compiler/baseCheck.ts(26,9): error TS2304: Cannot find name 'x'.
 
 
-==== tests/cases/compiler/baseCheck.ts (9 errors) ====
+==== tests/cases/compiler/baseCheck.ts (7 errors) ====
     class C { constructor(x: number, y: number) { } }
     class ELoc extends C {
         constructor(x: number) {
@@ -32,16 +30,12 @@ tests/cases/compiler/baseCheck.ts(26,9): error TS2304: Cannot find name 'x'.
     class D extends C { constructor(public z: number) { super(this.z) }  } // too few params
                                                         ~~~~~~~~~~~~~
 !!! error TS2554: Expected 2 arguments, but got 1.
-                                                              ~~~~
-!!! error TS17009: 'super' must be called before accessing 'this' in the constructor of a derived class.
     class E extends C { constructor(public z: number) { super(0, this.z) } }
                                                                  ~~~~
 !!! error TS17009: 'super' must be called before accessing 'this' in the constructor of a derived class.
     class F extends C { constructor(public z: number) { super("hello", this.z) } } // first param type
                                                               ~~~~~~~
 !!! error TS2345: Argument of type '"hello"' is not assignable to parameter of type 'number'.
-                                                                       ~~~~
-!!! error TS17009: 'super' must be called before accessing 'this' in the constructor of a derived class.
 
     function f() {
         if (x<10) {

tests/baselines/reference/blockScopedSameNameFunctionDeclarationES5.types

@@ -16,7 +16,7 @@ function foo(a: number) {
 >foo : { (): void; (): void; }
 
         foo(10); // not ok
->foo(10) : any
+>foo(10) : void
 >foo : { (): void; (): void; }
 >10 : 10
     }
@@ -29,12 +29,12 @@ function foo(a: number) {
 >foo : { (): void; (): void; }
 
         foo(10); // not ok
->foo(10) : any
+>foo(10) : void
 >foo : { (): void; (): void; }
 >10 : 10
     }
     foo(10); // not ok
->foo(10) : any
+>foo(10) : void
 >foo : { (): void; (): void; }
 >10 : 10
 

tests/baselines/reference/blockScopedSameNameFunctionDeclarationES6.types

@@ -16,7 +16,7 @@ function foo(a: number) {
 >foo : { (): void; (): void; }
 
         foo(10); // not ok
->foo(10) : any
+>foo(10) : void
 >foo : { (): void; (): void; }
 >10 : 10
     }
@@ -29,12 +29,12 @@ function foo(a: number) {
 >foo : { (): void; (): void; }
 
         foo(10);// not ok
->foo(10) : any
+>foo(10) : void
 >foo : { (): void; (): void; }
 >10 : 10
     }
     foo(10); // not ok
->foo(10) : any
+>foo(10) : void
 >foo : { (): void; (): void; }
 >10 : 10
 

tests/baselines/reference/callGenericFunctionWithIncorrectNumberOfTypeArguments.types

@@ -9,15 +9,15 @@ function f<T, U>(x: T, y: U): T { return null; }
 >null : null
 
 var r1 = f<number>(1, '');
->r1 : any
->f<number>(1, '') : any
+>r1 : number
+>f<number>(1, '') : number
 >f : <T, U>(x: T, y: U) => T
 >1 : 1
 >'' : ""
 
 var r1b = f<number, string, number>(1, '');
->r1b : any
->f<number, string, number>(1, '') : any
+>r1b : number
+>f<number, string, number>(1, '') : number
 >f : <T, U>(x: T, y: U) => T
 >1 : 1
 >'' : ""
@@ -30,15 +30,15 @@ var f2 = <T, U>(x: T, y: U): T => { return null; }
 >null : null
 
 var r2 = f2<number>(1, '');
->r2 : any
->f2<number>(1, '') : any
+>r2 : number
+>f2<number>(1, '') : number
 >f2 : <T, U>(x: T, y: U) => T
 >1 : 1
 >'' : ""
 
 var r2b = f2<number, string, number>(1, '');
->r2b : any
->f2<number, string, number>(1, '') : any
+>r2b : number
+>f2<number, string, number>(1, '') : number
 >f2 : <T, U>(x: T, y: U) => T
 >1 : 1
 >'' : ""
@@ -49,15 +49,15 @@ var f3: { <T, U>(x: T, y: U): T; }
 >y : U
 
 var r3 = f3<number>(1, '');
->r3 : any
->f3<number>(1, '') : any
+>r3 : number
+>f3<number>(1, '') : number
 >f3 : <T, U>(x: T, y: U) => T
 >1 : 1
 >'' : ""
 
 var r3b = f3<number, string, number>(1, '');
->r3b : any
->f3<number, string, number>(1, '') : any
+>r3b : number
+>f3<number, string, number>(1, '') : number
 >f3 : <T, U>(x: T, y: U) => T
 >1 : 1
 >'' : ""
@@ -75,8 +75,8 @@ class C {
     }
 }
 var r4 = (new C()).f<number>(1, '');
->r4 : any
->(new C()).f<number>(1, '') : any
+>r4 : number
+>(new C()).f<number>(1, '') : number
 >(new C()).f : <T, U>(x: T, y: U) => T
 >(new C()) : C
 >new C() : C
@@ -86,8 +86,8 @@ var r4 = (new C()).f<number>(1, '');
 >'' : ""
 
 var r4b = (new C()).f<number, string, number>(1, '');
->r4b : any
->(new C()).f<number, string, number>(1, '') : any
+>r4b : number
+>(new C()).f<number, string, number>(1, '') : number
 >(new C()).f : <T, U>(x: T, y: U) => T
 >(new C()) : C
 >new C() : C
@@ -106,17 +106,17 @@ var i: I;
 >i : I
 
 var r5 = i.f<number>(1, '');
->r5 : any
->i.f<number>(1, '') : any
+>r5 : number
+>i.f<number>(1, '') : number
 >i.f : <T, U>(x: T, y: U) => T
 >i : I
 >f : <T, U>(x: T, y: U) => T
 >1 : 1
 >'' : ""
 
 var r5b = i.f<number, string, number>(1, '');
->r5b : any
->i.f<number, string, number>(1, '') : any
+>r5b : number
+>i.f<number, string, number>(1, '') : number
 >i.f : <T, U>(x: T, y: U) => T
 >i : I
 >f : <T, U>(x: T, y: U) => T

tests/baselines/reference/callOnInstance.errors.txt

@@ -1,10 +1,11 @@
 tests/cases/compiler/callOnInstance.ts(1,18): error TS2300: Duplicate identifier 'D'.
 tests/cases/compiler/callOnInstance.ts(3,15): error TS2300: Duplicate identifier 'D'.
+tests/cases/compiler/callOnInstance.ts(7,19): error TS2350: Only a void function can be called with the 'new' keyword.
 tests/cases/compiler/callOnInstance.ts(7,19): error TS2554: Expected 0 arguments, but got 1.
 tests/cases/compiler/callOnInstance.ts(10,1): error TS2349: Cannot invoke an expression whose type lacks a call signature. Type 'C' has no compatible call signatures.
 
 
-==== tests/cases/compiler/callOnInstance.ts (4 errors) ====
+==== tests/cases/compiler/callOnInstance.ts (5 errors) ====
     declare function D(): string; // error
                      ~
 !!! error TS2300: Duplicate identifier 'D'.
@@ -17,6 +18,8 @@ tests/cases/compiler/callOnInstance.ts(10,1): error TS2349: Cannot invoke an exp
 
     var s2: string = (new D(1))();
                       ~~~~~~~~
+!!! error TS2350: Only a void function can be called with the 'new' keyword.
+                      ~~~~~~~~
 !!! error TS2554: Expected 0 arguments, but got 1.
 
     declare class C { constructor(value: number); }

tests/baselines/reference/callOverloads1.errors.txt

@@ -1,10 +1,11 @@
 tests/cases/compiler/callOverloads1.ts(1,7): error TS2300: Duplicate identifier 'Foo'.
 tests/cases/compiler/callOverloads1.ts(9,10): error TS2300: Duplicate identifier 'Foo'.
 tests/cases/compiler/callOverloads1.ts(9,10): error TS2391: Function implementation is missing or not immediately following the declaration.
+tests/cases/compiler/callOverloads1.ts(13,10): error TS2350: Only a void function can be called with the 'new' keyword.
 tests/cases/compiler/callOverloads1.ts(13,10): error TS2554: Expected 0 arguments, but got 1.
 
 
-==== tests/cases/compiler/callOverloads1.ts (4 errors) ====
+==== tests/cases/compiler/callOverloads1.ts (5 errors) ====
     class Foo { // error
           ~~~
 !!! error TS2300: Duplicate identifier 'Foo'.
@@ -25,6 +26,8 @@ tests/cases/compiler/callOverloads1.ts(13,10): error TS2554: Expected 0 argument
 
     var f1 = new Foo("hey");
              ~~~~~~~~~~~~~~
+!!! error TS2350: Only a void function can be called with the 'new' keyword.
+             ~~~~~~~~~~~~~~
 !!! error TS2554: Expected 0 arguments, but got 1.
 
 

tests/baselines/reference/callOverloads2.errors.txt

@@ -4,10 +4,11 @@ tests/cases/compiler/callOverloads2.ts(11,10): error TS2389: Function implementa
 tests/cases/compiler/callOverloads2.ts(11,10): error TS2393: Duplicate function implementation.
 tests/cases/compiler/callOverloads2.ts(12,10): error TS2393: Duplicate function implementation.
 tests/cases/compiler/callOverloads2.ts(14,10): error TS2391: Function implementation is missing or not immediately following the declaration.
+tests/cases/compiler/callOverloads2.ts(18,10): error TS2350: Only a void function can be called with the 'new' keyword.
 tests/cases/compiler/callOverloads2.ts(18,10): error TS2554: Expected 0 arguments, but got 1.
 
 
-==== tests/cases/compiler/callOverloads2.ts (7 errors) ====
+==== tests/cases/compiler/callOverloads2.ts (8 errors) ====
     class Foo { // error
           ~~~
 !!! error TS2300: Duplicate identifier 'Foo'.
@@ -39,6 +40,8 @@ tests/cases/compiler/callOverloads2.ts(18,10): error TS2554: Expected 0 argument
 
     var f1 = new Foo("hey");
              ~~~~~~~~~~~~~~
+!!! error TS2350: Only a void function can be called with the 'new' keyword.
+             ~~~~~~~~~~~~~~
 !!! error TS2554: Expected 0 arguments, but got 1.
 
 

tests/baselines/reference/callSignaturesShouldBeResolvedBeforeSpecialization.types

@@ -19,7 +19,7 @@ function foo() {
 >"expects boolean instead of string" : "expects boolean instead of string"
 
     test(true); // should error - string expected
->test(true) : any
+>test(true) : void
 >test : I1<string>
 >true : true
 }

tests/baselines/reference/callWithWrongNumberOfTypeArguments.types

@@ -3,14 +3,14 @@ function f<T, U>() { }
 >f : <T, U>() => void
 
 f<number>();
->f<number>() : any
+>f<number>() : void
 >f : <T, U>() => void
 
 f<number, string>();
 >f<number, string>() : void
 >f : <T, U>() => void
 
 f<number, string, number>();
->f<number, string, number>() : any
+>f<number, string, number>() : void
 >f : <T, U>() => void
 

tests/baselines/reference/chainedCallsWithTypeParameterConstrainedToOtherTypeParameter.errors.txt

@@ -1,9 +1,12 @@
 tests/cases/compiler/chainedCallsWithTypeParameterConstrainedToOtherTypeParameter.ts(19,59): error TS2345: Argument of type '(c: C) => B' is not assignable to parameter of type '(x: C) => C'.
   Type 'B' is not assignable to type 'C'.
     Property 'z' is missing in type 'B'.
+tests/cases/compiler/chainedCallsWithTypeParameterConstrainedToOtherTypeParameter.ts(19,76): error TS2345: Argument of type '(b: C) => A' is not assignable to parameter of type '(x: C) => C'.
+  Type 'A' is not assignable to type 'C'.
+    Property 'z' is missing in type 'A'.
 
 
-==== tests/cases/compiler/chainedCallsWithTypeParameterConstrainedToOtherTypeParameter.ts (1 errors) ====
+==== tests/cases/compiler/chainedCallsWithTypeParameterConstrainedToOtherTypeParameter.ts (2 errors) ====
     class Chain<T extends A> {
         constructor(public value: T) { }
         then<S extends T>(cb: (x: T) => S): Chain<S> {
@@ -26,4 +29,8 @@ tests/cases/compiler/chainedCallsWithTypeParameterConstrainedToOtherTypeParamete
                                                               ~~~~~~~~~~
 !!! error TS2345: Argument of type '(c: C) => B' is not assignable to parameter of type '(x: C) => C'.
 !!! error TS2345:   Type 'B' is not assignable to type 'C'.
-!!! error TS2345:     Property 'z' is missing in type 'B'.
+!!! error TS2345:     Property 'z' is missing in type 'B'.
+                                                                               ~~~~~~~~~~
+!!! error TS2345: Argument of type '(b: C) => A' is not assignable to parameter of type '(x: C) => C'.
+!!! error TS2345:   Type 'A' is not assignable to type 'C'.
+!!! error TS2345:     Property 'z' is missing in type 'A'.

tests/baselines/reference/chainedCallsWithTypeParameterConstrainedToOtherTypeParameter.symbols

@@ -46,6 +46,7 @@ class C extends B {
 
 // Ok to go down the chain, but error to try to climb back up
 (new Chain(new A)).then(a => new B).then(b => new C).then(c => new B).then(b => new A);
+>(new Chain(new A)).then(a => new B).then(b => new C).then(c => new B).then : Symbol(Chain.then, Decl(chainedCallsWithTypeParameterConstrainedToOtherTypeParameter.ts, 1, 36))
 >(new Chain(new A)).then(a => new B).then(b => new C).then : Symbol(Chain.then, Decl(chainedCallsWithTypeParameterConstrainedToOtherTypeParameter.ts, 1, 36))
 >(new Chain(new A)).then(a => new B).then : Symbol(Chain.then, Decl(chainedCallsWithTypeParameterConstrainedToOtherTypeParameter.ts, 1, 36))
 >(new Chain(new A)).then : Symbol(Chain.then, Decl(chainedCallsWithTypeParameterConstrainedToOtherTypeParameter.ts, 1, 36))
@@ -60,6 +61,7 @@ class C extends B {
 >then : Symbol(Chain.then, Decl(chainedCallsWithTypeParameterConstrainedToOtherTypeParameter.ts, 1, 36))
 >c : Symbol(c, Decl(chainedCallsWithTypeParameterConstrainedToOtherTypeParameter.ts, 18, 58))
 >B : Symbol(B, Decl(chainedCallsWithTypeParameterConstrainedToOtherTypeParameter.ts, 9, 1))
+>then : Symbol(Chain.then, Decl(chainedCallsWithTypeParameterConstrainedToOtherTypeParameter.ts, 1, 36))
 >b : Symbol(b, Decl(chainedCallsWithTypeParameterConstrainedToOtherTypeParameter.ts, 18, 75))
 >A : Symbol(A, Decl(chainedCallsWithTypeParameterConstrainedToOtherTypeParameter.ts, 5, 1))
 

tests/baselines/reference/chainedCallsWithTypeParameterConstrainedToOtherTypeParameter.types

@@ -38,9 +38,9 @@ class C extends B {
 
 // Ok to go down the chain, but error to try to climb back up
 (new Chain(new A)).then(a => new B).then(b => new C).then(c => new B).then(b => new A);
->(new Chain(new A)).then(a => new B).then(b => new C).then(c => new B).then(b => new A) : any
->(new Chain(new A)).then(a => new B).then(b => new C).then(c => new B).then : any
->(new Chain(new A)).then(a => new B).then(b => new C).then(c => new B) : any
+>(new Chain(new A)).then(a => new B).then(b => new C).then(c => new B).then(b => new A) : Chain<C>
+>(new Chain(new A)).then(a => new B).then(b => new C).then(c => new B).then : <S extends C>(cb: (x: C) => S) => Chain<S>
+>(new Chain(new A)).then(a => new B).then(b => new C).then(c => new B) : Chain<C>
 >(new Chain(new A)).then(a => new B).then(b => new C).then : <S extends C>(cb: (x: C) => S) => Chain<S>
 >(new Chain(new A)).then(a => new B).then(b => new C) : Chain<C>
 >(new Chain(new A)).then(a => new B).then : <S extends B>(cb: (x: B) => S) => Chain<S>
@@ -66,9 +66,9 @@ class C extends B {
 >c : C
 >new B : B
 >B : typeof B
->then : any
->b => new A : (b: any) => A
->b : any
+>then : <S extends C>(cb: (x: C) => S) => Chain<S>
+>b => new A : (b: C) => A
+>b : C
 >new A : A
 >A : typeof A
 

tests/baselines/reference/chainedCallsWithTypeParameterConstrainedToOtherTypeParameter2.types

@@ -18,7 +18,7 @@ class Chain<T> {
 
         // Ok to go down the chain, but error to climb up the chain
         (new Chain(t)).then(tt => s).then(ss => t);
->(new Chain(t)).then(tt => s).then(ss => t) : any
+>(new Chain(t)).then(tt => s).then(ss => t) : Chain<S>
 >(new Chain(t)).then(tt => s).then : <S extends S>(cb: (x: S) => S) => Chain<S>
 >(new Chain(t)).then(tt => s) : Chain<S>
 >(new Chain(t)).then : <S extends T>(cb: (x: T) => S) => Chain<S>
@@ -37,7 +37,7 @@ class Chain<T> {
 
         // But error to try to climb up the chain
         (new Chain(s)).then(ss => t);
->(new Chain(s)).then(ss => t) : any
+>(new Chain(s)).then(ss => t) : Chain<S>
 >(new Chain(s)).then : <S extends S>(cb: (x: S) => S) => Chain<S>
 >(new Chain(s)) : Chain<S>
 >new Chain(s) : Chain<S>