Exclude tuples from suggestion

Author: sandersn

src/compiler/checker.ts

@@ -19580,6 +19580,7 @@ namespace ts {
         }
 
         function getExactOptionalUnassignableProperties(source: Type, target: Type) {
+            if (isTupleType(source) && isTupleType(target)) return emptyArray;
             return getPropertiesOfType(target)
                 .filter(targetProp => isExactOptionalPropertyMismatch(getTypeOfPropertyOfType(source, targetProp.escapedName), getTypeOfSymbol(targetProp)));
         }

tests/baselines/reference/strictOptionalProperties1.errors.txt

@@ -5,25 +5,25 @@ tests/cases/compiler/strictOptionalProperties1.ts(20,9): error TS2412: Type 'und
 tests/cases/compiler/strictOptionalProperties1.ts(28,9): error TS2412: Type 'undefined' is not assignable to type 'string' with 'exactOptionalPropertyTypes: true'. Consider adding 'undefined' to the type of the target.
 tests/cases/compiler/strictOptionalProperties1.ts(53,5): error TS2412: Type 'undefined' is not assignable to type 'string' with 'exactOptionalPropertyTypes: true'. Consider adding 'undefined' to the type of the target.
 tests/cases/compiler/strictOptionalProperties1.ts(60,5): error TS2322: Type 'undefined' is not assignable to type 'string'.
-tests/cases/compiler/strictOptionalProperties1.ts(64,5): error TS2375: Type '[number, string?, string?]' is not assignable to type '[number, string?]' with 'exactOptionalPropertyTypes: true'. Consider adding 'undefined' to the types of the target's properties.
+tests/cases/compiler/strictOptionalProperties1.ts(64,5): error TS2322: Type '[number, string?, string?]' is not assignable to type '[number, string?]'.
   Target allows only 2 element(s) but source may have more.
-tests/cases/compiler/strictOptionalProperties1.ts(73,5): error TS2375: Type '[number, never?, never?, never?]' is not assignable to type '[number, string?, boolean?]' with 'exactOptionalPropertyTypes: true'. Consider adding 'undefined' to the types of the target's properties.
+tests/cases/compiler/strictOptionalProperties1.ts(73,5): error TS2322: Type '[number, never?, never?, never?]' is not assignable to type '[number, string?, boolean?]'.
   Target allows only 3 element(s) but source may have more.
-tests/cases/compiler/strictOptionalProperties1.ts(74,5): error TS2375: Type '[never?, never?, true?]' is not assignable to type '[number, string?, boolean?]' with 'exactOptionalPropertyTypes: true'. Consider adding 'undefined' to the types of the target's properties.
+tests/cases/compiler/strictOptionalProperties1.ts(74,5): error TS2322: Type '[never?, never?, true?]' is not assignable to type '[number, string?, boolean?]'.
   Source provides no match for required element at position 0 in target.
-tests/cases/compiler/strictOptionalProperties1.ts(75,5): error TS2375: Type '[number, undefined, true]' is not assignable to type '[number, string?, boolean?]' with 'exactOptionalPropertyTypes: true'. Consider adding 'undefined' to the types of the target's properties.
+tests/cases/compiler/strictOptionalProperties1.ts(75,5): error TS2322: Type '[number, undefined, true]' is not assignable to type '[number, string?, boolean?]'.
   Type at position 1 in source is not compatible with type at position 1 in target.
     Type 'undefined' is not assignable to type 'string'.
 tests/cases/compiler/strictOptionalProperties1.ts(99,7): error TS2375: Type '{ foo: undefined; bar: string; }' is not assignable to type 'InputProps' with 'exactOptionalPropertyTypes: true'. Consider adding 'undefined' to the types of the target's properties.
   Types of property 'foo' are incompatible.
     Type 'undefined' is not assignable to type 'string'.
-tests/cases/compiler/strictOptionalProperties1.ts(105,7): error TS2375: Type '[number, undefined]' is not assignable to type '[number, string?, boolean?]' with 'exactOptionalPropertyTypes: true'. Consider adding 'undefined' to the types of the target's properties.
+tests/cases/compiler/strictOptionalProperties1.ts(105,7): error TS2322: Type '[number, undefined]' is not assignable to type '[number, string?, boolean?]'.
   Type at position 1 in source is not compatible with type at position 1 in target.
     Type 'undefined' is not assignable to type 'string'.
-tests/cases/compiler/strictOptionalProperties1.ts(106,7): error TS2375: Type '[number, string, undefined]' is not assignable to type '[number, string?, boolean?]' with 'exactOptionalPropertyTypes: true'. Consider adding 'undefined' to the types of the target's properties.
+tests/cases/compiler/strictOptionalProperties1.ts(106,7): error TS2322: Type '[number, string, undefined]' is not assignable to type '[number, string?, boolean?]'.
   Type at position 2 in source is not compatible with type at position 2 in target.
     Type 'undefined' is not assignable to type 'boolean'.
-tests/cases/compiler/strictOptionalProperties1.ts(107,7): error TS2375: Type '[number, undefined, undefined]' is not assignable to type '[number, string?, boolean?]' with 'exactOptionalPropertyTypes: true'. Consider adding 'undefined' to the types of the target's properties.
+tests/cases/compiler/strictOptionalProperties1.ts(107,7): error TS2322: Type '[number, undefined, undefined]' is not assignable to type '[number, string?, boolean?]'.
   Type at position 1 in source is not compatible with type at position 1 in target.
     Type 'undefined' is not assignable to type 'string'.
 tests/cases/compiler/strictOptionalProperties1.ts(111,7): error TS2375: Type '{ foo: undefined; }' is not assignable to type '{ foo?: number; }' with 'exactOptionalPropertyTypes: true'. Consider adding 'undefined' to the types of the target's properties.
@@ -118,8 +118,8 @@ tests/cases/compiler/strictOptionalProperties1.ts(195,1): error TS2375: Type '{
     function f4a(t1: [number, string?], t2: [number, string?, string?]) {
         t1 = t2;  // Wasn't an error, but should be
         ~~
-!!! error TS2375: Type '[number, string?, string?]' is not assignable to type '[number, string?]' with 'exactOptionalPropertyTypes: true'. Consider adding 'undefined' to the types of the target's properties.
-!!! error TS2375:   Target allows only 2 element(s) but source may have more.
+!!! error TS2322: Type '[number, string?, string?]' is not assignable to type '[number, string?]'.
+!!! error TS2322:   Target allows only 2 element(s) but source may have more.
     }
 
     function f5(t: [number, string?, boolean?]) {
@@ -130,17 +130,17 @@ tests/cases/compiler/strictOptionalProperties1.ts(195,1): error TS2375: Type '{
         t = [42, , ,];
         t = [42, , , ,];  // Error
         ~
-!!! error TS2375: Type '[number, never?, never?, never?]' is not assignable to type '[number, string?, boolean?]' with 'exactOptionalPropertyTypes: true'. Consider adding 'undefined' to the types of the target's properties.
-!!! error TS2375:   Target allows only 3 element(s) but source may have more.
+!!! error TS2322: Type '[number, never?, never?, never?]' is not assignable to type '[number, string?, boolean?]'.
+!!! error TS2322:   Target allows only 3 element(s) but source may have more.
         t = [, , true];  // Error
         ~
-!!! error TS2375: Type '[never?, never?, true?]' is not assignable to type '[number, string?, boolean?]' with 'exactOptionalPropertyTypes: true'. Consider adding 'undefined' to the types of the target's properties.
-!!! error TS2375:   Source provides no match for required element at position 0 in target.
+!!! error TS2322: Type '[never?, never?, true?]' is not assignable to type '[number, string?, boolean?]'.
+!!! error TS2322:   Source provides no match for required element at position 0 in target.
         t = [42, undefined, true];  // Error
         ~
-!!! error TS2375: Type '[number, undefined, true]' is not assignable to type '[number, string?, boolean?]' with 'exactOptionalPropertyTypes: true'. Consider adding 'undefined' to the types of the target's properties.
-!!! error TS2375:   Type at position 1 in source is not compatible with type at position 1 in target.
-!!! error TS2375:     Type 'undefined' is not assignable to type 'string'.
+!!! error TS2322: Type '[number, undefined, true]' is not assignable to type '[number, string?, boolean?]'.
+!!! error TS2322:   Type at position 1 in source is not compatible with type at position 1 in target.
+!!! error TS2322:     Type 'undefined' is not assignable to type 'string'.
     }
 
     function f6() {
@@ -176,19 +176,19 @@ tests/cases/compiler/strictOptionalProperties1.ts(195,1): error TS2375: Type '{
     const t1: [number, string?, boolean?] = [1];
     const t2: [number, string?, boolean?] = [1, undefined];
           ~~
-!!! error TS2375: Type '[number, undefined]' is not assignable to type '[number, string?, boolean?]' with 'exactOptionalPropertyTypes: true'. Consider adding 'undefined' to the types of the target's properties.
-!!! error TS2375:   Type at position 1 in source is not compatible with type at position 1 in target.
-!!! error TS2375:     Type 'undefined' is not assignable to type 'string'.
+!!! error TS2322: Type '[number, undefined]' is not assignable to type '[number, string?, boolean?]'.
+!!! error TS2322:   Type at position 1 in source is not compatible with type at position 1 in target.
+!!! error TS2322:     Type 'undefined' is not assignable to type 'string'.
     const t3: [number, string?, boolean?] = [1, "string", undefined];
           ~~
-!!! error TS2375: Type '[number, string, undefined]' is not assignable to type '[number, string?, boolean?]' with 'exactOptionalPropertyTypes: true'. Consider adding 'undefined' to the types of the target's properties.
-!!! error TS2375:   Type at position 2 in source is not compatible with type at position 2 in target.
-!!! error TS2375:     Type 'undefined' is not assignable to type 'boolean'.
+!!! error TS2322: Type '[number, string, undefined]' is not assignable to type '[number, string?, boolean?]'.
+!!! error TS2322:   Type at position 2 in source is not compatible with type at position 2 in target.
+!!! error TS2322:     Type 'undefined' is not assignable to type 'boolean'.
     const t4: [number, string?, boolean?] = [1, undefined, undefined];
           ~~
-!!! error TS2375: Type '[number, undefined, undefined]' is not assignable to type '[number, string?, boolean?]' with 'exactOptionalPropertyTypes: true'. Consider adding 'undefined' to the types of the target's properties.
-!!! error TS2375:   Type at position 1 in source is not compatible with type at position 1 in target.
-!!! error TS2375:     Type 'undefined' is not assignable to type 'string'.
+!!! error TS2322: Type '[number, undefined, undefined]' is not assignable to type '[number, string?, boolean?]'.
+!!! error TS2322:   Type at position 1 in source is not compatible with type at position 1 in target.
+!!! error TS2322:     Type 'undefined' is not assignable to type 'string'.
 
     // Example from #13195