Revert "Use NonNullable<T> in more scenarios (#49330)"

This reverts commit 3cdb808.

Author: DanielRosenwasser

src/compiler/checker.ts

@@ -14,8 +14,8 @@ function Menu<MenuItemVariant extends ListItemVariant = ListItemVariant.OneLine>
 >data : IData<MenuItemVariant>
 
     const listItemVariant = data.menuItemsVariant ?? ListItemVariant.OneLine;
->listItemVariant : ListItemVariant.OneLine | MenuItemVariant
->data.menuItemsVariant ?? ListItemVariant.OneLine : ListItemVariant.OneLine | MenuItemVariant
+>listItemVariant : ListItemVariant.OneLine | NonNullable<MenuItemVariant>
+>data.menuItemsVariant ?? ListItemVariant.OneLine : ListItemVariant.OneLine | NonNullable<MenuItemVariant>
 >data.menuItemsVariant : MenuItemVariant | undefined
 >data : IData<MenuItemVariant>
 >menuItemsVariant : MenuItemVariant | undefined

tests/baselines/reference/discriminatedUnionJsxElement.types

@@ -30,14 +30,14 @@ function boxify<T>(obj: T): Boxified<T> {
 >obj : (T & null) | (T & object)
 
             result[k] = { value: obj[k] };
->result[k] = { value: obj[k] } : { value: (T & object)[Extract<keyof T, string>]; }
+>result[k] = { value: obj[k] } : { value: NonNullable<T & object>[Extract<keyof T, string>]; }
 >result[k] : Boxified<T>[Extract<keyof T, string>]
 >result : Boxified<T>
 >k : Extract<keyof T, string>
->{ value: obj[k] } : { value: (T & object)[Extract<keyof T, string>]; }
->value : (T & object)[Extract<keyof T, string>]
->obj[k] : (T & object)[Extract<keyof T, string>]
->obj : T & object
+>{ value: obj[k] } : { value: NonNullable<T & object>[Extract<keyof T, string>]; }
+>value : NonNullable<T & object>[Extract<keyof T, string>]
+>obj[k] : NonNullable<T & object>[Extract<keyof T, string>]
+>obj : NonNullable<T & object>
 >k : Extract<keyof T, string>
         }
         return result;

tests/baselines/reference/mappedTypes4.types

@@ -180,7 +180,7 @@ declare function infiniteLoop1(): void;
 declare function infiniteLoop2(): never;
 declare function move1(direction: "up" | "down"): 1 | -1;
 declare function move2(direction: "up" | "down"): 1 | -1;
-declare function check<T>(x: T | undefined): NonNullable<T>;
+declare function check<T>(x: T | undefined): T;
 declare class C {
     void1(): void;
     void2(): void;

tests/baselines/reference/neverType.js

@@ -112,11 +112,11 @@ function move2(direction: "up" | "down") {
 }
 
 function check<T>(x: T | undefined) {
->check : <T>(x: T | undefined) => NonNullable<T>
+>check : <T>(x: T | undefined) => T
 >x : T | undefined
 
     return x || error("Undefined value");
->x || error("Undefined value") : NonNullable<T>
+>x || error("Undefined value") : T
 >x : T | undefined
 >error("Undefined value") : never
 >error : (message: string) => never

tests/baselines/reference/neverType.types

@@ -25,7 +25,7 @@ function fn<T extends string | undefined, U extends string>(one: T, two: U) {
     foo(two!);
 >foo(two!) : void
 >foo : (p: string) => void
->two! : U
+>two! : NonNullable<U>
 >two : U
 
     foo(three!); // this line is the important one

tests/baselines/reference/nonNullParameterExtendingStringAssignableToString.types

@@ -75,8 +75,8 @@ const aa6 = a6 ?? 'whatever'
 >'whatever' : "whatever"
 
 const aa7 = a7 ?? 'whatever'
->aa7 : {}
->a7 ?? 'whatever' : {}
+>aa7 : unknown
+>a7 ?? 'whatever' : unknown
 >a7 : unknown
 >'whatever' : "whatever"
 

tests/baselines/reference/nonNullableTypes1.js

@@ -75,8 +75,8 @@ const aa6 = a6 ?? 'whatever'
 >'whatever' : "whatever"
 
 const aa7 = a7 ?? 'whatever'
->aa7 : {}
->a7 ?? 'whatever' : {}
+>aa7 : unknown
+>a7 ?? 'whatever' : unknown
 >a7 : unknown
 >'whatever' : "whatever"
 

tests/baselines/reference/nonNullableTypes1.symbols

@@ -28,10 +28,10 @@ class A {
 
         this?.getA().#b;    // Error
 >this?.getA().#b : A | undefined
->this?.getA() : A
->this?.getA : () => A
+>this?.getA() : A | undefined
+>this?.getA : (() => A) | undefined
 >this : this
->getA : () => A
+>getA : (() => A) | undefined
     }
 }
 

tests/baselines/reference/nonNullableTypes1.types

@@ -15,7 +15,7 @@ function JustConditional<T>(): ConditionalType<T> {
 >JustConditional : <T>() => ConditionalType<T>
 
     return ConditionalOrUndefined<T>()!; // shouldn't error
->ConditionalOrUndefined<T>()! : ConditionalType<T>
+>ConditionalOrUndefined<T>()! : NonNullable<ConditionalType<T>>
 >ConditionalOrUndefined<T>() : ConditionalType<T> | undefined
 >ConditionalOrUndefined : <T>() => ConditionalType<T> | undefined
 }