Skip to content

Suppress console.log & others inside the TS Server runtime so that language service plugins don't accidentally use them and kill the server #32668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2019
Merged

Suppress console.log & others inside the TS Server runtime so that language service plugins don't accidentally use them and kill the server #32668

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f04c7ed
Supress console.log & others inside the TS Server runtime so that lan…
orta Aug 1, 2019
f8b7a05
Handle the variadic args for inline console.logs
orta Aug 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/tsserver/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -970,4 +970,12 @@ namespace ts.server {
if (ts.sys.tryEnableSourceMapsForHost && /^development$/i.test(ts.sys.getEnvironmentVariable("NODE_ENV"))) {
ts.sys.tryEnableSourceMapsForHost();
}

// Overwrites the current console messages to instead write to
// the log. This is so that language service plugins which use
// console.log don't break the message passing between tsserver
// and the client
console.log = (...args) => logger.msg(args.length === 1 ? args[0] : args.join(", "), Msg.Info);
console.warn = (...args) => logger.msg(args.length === 1 ? args[0] : args.join(", "), Msg.Err);
console.error = (...args) => logger.msg(args.length === 1 ? args[0] : args.join(", "), Msg.Err);
}