Skip to content

Add missing visitor of template literal type #40738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2020
Merged

Add missing visitor of template literal type #40738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11b73ba
Add missing visitor of template literal type
Kingwl Sep 24, 2020
80a65b2
make linter happy
Kingwl Sep 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/compiler/factory/nodeTests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,10 @@ namespace ts {
return node.kind === SyntaxKind.ImportType;
}

export function isTemplateLiteralTypeSpan(node: Node): node is TemplateLiteralTypeSpan {
return node.kind === SyntaxKind.TemplateLiteralTypeSpan;
}

// Binding patterns

export function isObjectBindingPattern(node: Node): node is ObjectBindingPattern {
Expand Down
10 changes: 10 additions & 0 deletions src/compiler/visitorPublic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,6 +573,16 @@ namespace ts {
return factory.updateLiteralTypeNode(<LiteralTypeNode>node,
nodeVisitor((<LiteralTypeNode>node).literal, visitor, isExpression));

case SyntaxKind.TemplateLiteralType:
return factory.updateTemplateLiteralType(<TemplateLiteralTypeNode>node,
nodeVisitor((<TemplateLiteralTypeNode>node).head, visitor, isTemplateHead),
nodesVisitor((<TemplateLiteralTypeNode>node).templateSpans, visitor, isTemplateLiteralTypeSpan));

case SyntaxKind.TemplateLiteralTypeSpan:
return factory.updateTemplateLiteralTypeSpan(<TemplateLiteralTypeSpan>node,
nodeVisitor((<TemplateLiteralTypeSpan>node).type, visitor, isTypeNode),
nodeVisitor((<TemplateLiteralTypeSpan>node).literal, visitor, isTemplateMiddleOrTemplateTail));

// Binding patterns
case SyntaxKind.ObjectBindingPattern:
return factory.updateObjectBindingPattern(<ObjectBindingPattern>node,
Expand Down
1 change: 1 addition & 0 deletions tests/baselines/reference/api/tsserverlibrary.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4368,6 +4368,7 @@ declare namespace ts {
function isMappedTypeNode(node: Node): node is MappedTypeNode;
function isLiteralTypeNode(node: Node): node is LiteralTypeNode;
function isImportTypeNode(node: Node): node is ImportTypeNode;
function isTemplateLiteralTypeSpan(node: Node): node is TemplateLiteralTypeSpan;
function isObjectBindingPattern(node: Node): node is ObjectBindingPattern;
function isArrayBindingPattern(node: Node): node is ArrayBindingPattern;
function isBindingElement(node: Node): node is BindingElement;
Expand Down
1 change: 1 addition & 0 deletions tests/baselines/reference/api/typescript.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4368,6 +4368,7 @@ declare namespace ts {
function isMappedTypeNode(node: Node): node is MappedTypeNode;
function isLiteralTypeNode(node: Node): node is LiteralTypeNode;
function isImportTypeNode(node: Node): node is ImportTypeNode;
function isTemplateLiteralTypeSpan(node: Node): node is TemplateLiteralTypeSpan;
function isObjectBindingPattern(node: Node): node is ObjectBindingPattern;
function isArrayBindingPattern(node: Node): node is ArrayBindingPattern;
function isBindingElement(node: Node): node is BindingElement;
Expand Down