fix: crashes when JSX.IntrinsicClassAttributes is an alias type close GH-50254 #50257
Conversation
typescript-bot
added
the
For Uncommitted Bug
|
Thanks! |
| if (typeParams && typeParams.length === 1) { | ||
| const inferredArgs = fillMissingTypeArguments([hostClassType], typeParams, getMinTypeArgumentCount(typeParams), isInJSFile(context)); |
There was a problem hiding this comment.
oh, since I checked the typeParams length, I should not call fillMissingTypeArguments.
Which is preferred? To limit the generics number of JSX.IntrinsicClassAttributes = 1, or allow any argument count and call fillMissingTypeArguments to fill it?
There was a problem hiding this comment.
I usually err on the side of being permissive, since we've never surfaced real errors for these intrinsic types - so allowing too many arguments, but only providing the first and defaulting/constraint'ing the rest. Not much reasoning for either way, though. It's essentially a quiet error case.
There was a problem hiding this comment.
Actually, they're not intrinsic types, they're installed from npm. That's also true for libes6.d.ts etc, you can use nolib and provide you're own Promise<T> type. Maybe there's more incorrect cast in the checker assuming the shape of the library types and might crash under some edge cases.
There was a problem hiding this comment.
Most use the getGlobalType function which issues an error if arity doesn't match what we expect. The JSX types have just always been a bit more lax.
There was a problem hiding this comment.
I opened #50271 to clean up the code.
Fixes #50254