Clean up a few function signatures and function calls.

Author: iclanton

libraries/rush-lib/src/api/LastLinkFlag.ts

@@ -58,6 +58,6 @@ export class LastLinkFlagFactory {
    * @internal
    */
   public static getCommonTempFlag(subspace: Subspace): LastLinkFlag {
-    return new LastLinkFlag(subspace.getSubspaceTempFolder(), {});
+    return new LastLinkFlag(subspace.getSubspaceTempFolder());
   }
 }

libraries/rush-lib/src/cli/actions/BaseInstallAction.ts

@@ -185,7 +185,7 @@ export abstract class BaseInstallAction extends BaseRushAction {
         });
       }
     } else {
-      VersionMismatchFinder.ensureConsistentVersions(this.rushConfiguration, this._terminal, {});
+      VersionMismatchFinder.ensureConsistentVersions(this.rushConfiguration, this._terminal);
     }
 
     const stopwatch: Stopwatch = Stopwatch.start();

libraries/rush-lib/src/logic/PackageJsonUpdater.ts

@@ -215,8 +215,7 @@ export class PackageJsonUpdater {
 
     if (updateOtherPackages) {
       const mismatchFinder: VersionMismatchFinder = VersionMismatchFinder.getMismatches(
-        this._rushConfiguration,
-        {}
+        this._rushConfiguration
       );
       for (const update of this._getUpdates(mismatchFinder, allDependenciesToUpdate)) {
         this.updateProject(update);
@@ -390,8 +389,7 @@ export class PackageJsonUpdater {
       // we need to do a mismatch check
       if (updateOtherPackages) {
         const mismatchFinder: VersionMismatchFinder = VersionMismatchFinder.getMismatches(
-          this._rushConfiguration,
-          {}
+          this._rushConfiguration
         );
         otherPackageUpdates = this._getUpdates(mismatchFinder, Object.entries(dependenciesToAddOrUpdate));
       }

libraries/rush-lib/src/logic/base/BaseInstallManager.ts

@@ -425,8 +425,7 @@ export abstract class BaseInstallManager {
       await PnpmfileConfiguration.writeCommonTempPnpmfileShimAsync(
         this.rushConfiguration,
         subspace.getSubspaceTempFolder(),
-        subspace,
-        this.options
+        subspace
       );
 
       if (this.rushConfiguration.subspacesFeatureEnabled) {

libraries/rush-lib/src/logic/pnpm/PnpmShrinkwrapFile.ts

@@ -719,8 +719,7 @@ export class PnpmShrinkwrapFile extends BaseShrinkwrapFile {
     if (!this._pnpmfileConfiguration) {
       this._pnpmfileConfiguration = await PnpmfileConfiguration.initializeAsync(
         project.rushConfiguration,
-        subspace,
-        {}
+        subspace
       );
     }
 

libraries/rush-lib/src/logic/pnpm/PnpmfileConfiguration.ts

@@ -14,11 +14,6 @@ import { pnpmfileShimFilename, scriptsFolderPath } from '../../utilities/PathCon
 import type { IPnpmfileContext, IPnpmfileShimSettings } from './IPnpmfile';
 import type { Subspace } from '../../api/Subspace';
 
-/**
- * Options used when generating the pnpmfile shim settings file.
- */
-export interface IPnpmfileShimOptions {}
-
 /**
  * Loads PNPM's pnpmfile.js configuration, and invokes it to preprocess package.json files,
  * optionally utilizing a pnpmfile shim to inject preferred versions.
@@ -32,8 +27,7 @@ export class PnpmfileConfiguration {
 
   public static async initializeAsync(
     rushConfiguration: RushConfiguration,
-    subspace: Subspace,
-    pnpmfileShimOptions?: IPnpmfileShimOptions
+    subspace: Subspace
   ): Promise<PnpmfileConfiguration> {
     if (rushConfiguration.packageManager !== 'pnpm') {
       throw new Error(
@@ -46,8 +40,7 @@ export class PnpmfileConfiguration {
       log: (message: string) => {},
       pnpmfileShimSettings: await PnpmfileConfiguration._getPnpmfileShimSettingsAsync(
         rushConfiguration,
-        subspace,
-        pnpmfileShimOptions
+        subspace
       )
     };
 
@@ -57,8 +50,7 @@ export class PnpmfileConfiguration {
   public static async writeCommonTempPnpmfileShimAsync(
     rushConfiguration: RushConfiguration,
     targetDir: string,
-    subspace: Subspace,
-    options?: IPnpmfileShimOptions
+    subspace: Subspace
   ): Promise<void> {
     if (rushConfiguration.packageManager !== 'pnpm') {
       throw new Error(
@@ -78,7 +70,7 @@ export class PnpmfileConfiguration {
     });
 
     const pnpmfileShimSettings: IPnpmfileShimSettings =
-      await PnpmfileConfiguration._getPnpmfileShimSettingsAsync(rushConfiguration, subspace, options);
+      await PnpmfileConfiguration._getPnpmfileShimSettingsAsync(rushConfiguration, subspace);
 
     // Write the settings file used by the shim
     await JsonFile.saveAsync(pnpmfileShimSettings, path.join(targetDir, 'pnpmfileSettings.json'), {
@@ -88,8 +80,7 @@ export class PnpmfileConfiguration {
 
   private static async _getPnpmfileShimSettingsAsync(
     rushConfiguration: RushConfiguration,
-    subspace: Subspace,
-    options?: IPnpmfileShimOptions
+    subspace: Subspace
   ): Promise<IPnpmfileShimSettings> {
     let allPreferredVersions: { [dependencyName: string]: string } = {};
     let allowedAlternativeVersions: { [dependencyName: string]: readonly string[] } = {};

libraries/rush-lib/src/logic/versionMismatch/VersionMismatchFinder.ts

@@ -134,10 +134,7 @@ export class VersionMismatchFinder {
     }
   ): void {
     if (rushConfiguration.ensureConsistentVersions || options.isRushCheckCommand) {
-      const mismatchFinder: VersionMismatchFinder = VersionMismatchFinder.getMismatches(
-        rushConfiguration,
-        {}
-      );
+      const mismatchFinder: VersionMismatchFinder = VersionMismatchFinder.getMismatches(rushConfiguration);
 
       if (options.printAsJson) {
         mismatchFinder.printAsJson();